Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QIODevice needs closing (and other end-of-request signals) #1

Open
halfgaar opened this issue May 11, 2020 · 0 comments
Open

QIODevice needs closing (and other end-of-request signals) #1

halfgaar opened this issue May 11, 2020 · 0 comments

Comments

@halfgaar
Copy link

The project may be stale, but I'm happily using it, so here goes:

QFCgiStream is a derived QIODevice. As the docs for ~QIODevice say:

This destructor does not call close(), but the subclass destructor might. If you are in doubt, call close() before destroying the QIODevice.

If I implement that, it properly fires the aboutToClose() signal, which I need for resource cleanup. The QFCgiRequest may actually also need some signals for that, (like connectionClosed() or requestEnded() (the difference may be keep-alive connections, of which I don't know (yet) how they work in FCGI).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant