Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to use BeerXML files #11

Open
drodil opened this issue Oct 23, 2019 · 5 comments
Open

Add support to use BeerXML files #11

drodil opened this issue Oct 23, 2019 · 5 comments
Labels
enhancement New feature or request hacktorberfest help wanted Extra attention is needed

Comments

@drodil
Copy link
Owner

drodil commented Oct 23, 2019

To be able to calculate for example IBU or SRM we need the incredients from the recipe. Add support for parsing BeerXML to an internal representation of the recipe that can be used by the commands.

See specification here: http://www.beerxml.com/

@drodil drodil added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktorberfest and removed good first issue Good for newcomers labels Oct 23, 2019
@mlatief
Copy link
Collaborator

mlatief commented Oct 23, 2019

I dread XML files, and I found there's already BeerYAML https://beeryaml.readthedocs.io/en/latest/. Also aligned with our initial thought of having parameters specified in YAML (didn't know BeerXML exists!)

@mlatief
Copy link
Collaborator

mlatief commented Oct 23, 2019

we can also create this a separate crate, something like (e.g. beeryaml-rust)

@drodil
Copy link
Owner Author

drodil commented Oct 23, 2019

BeerXML is supported by many of the brewing tools and didn't know BeerYAML existed :D Maybe we could do a new crate for that and maybe also something to convert between these two formats ;)

@flauntingspade4
Copy link
Contributor

Perhaps BeerJSON would be a good fit, as it's more readable, and not as verbose as xml?

@drodil
Copy link
Owner Author

drodil commented Oct 5, 2020

@flauntingspade4 true. We'll look into that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktorberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants