Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The atomic-polyfill crate is deprecated. #140

Closed
kefran06 opened this issue Apr 11, 2024 · 2 comments · Fixed by #141
Closed

The atomic-polyfill crate is deprecated. #140

kefran06 opened this issue Apr 11, 2024 · 2 comments · Fixed by #141

Comments

@kefran06
Copy link

The atomic-polyfill crates is deprecated and it is recommended that the portable-atomic crate be used instead.
(https://github.com/embassy-rs/atomic-polyfill)
Is it possible to change to use the portable-atomic crate?

※ Currently, on the xtensa-esp32-espidf target, the atomic-polyfill causes a compile error.

error[E0432]: unresolved import core::sync::atomic::AtomicU64

@lulf
Copy link
Member

lulf commented Apr 12, 2024

Yeah, that sounds good. Would you like to open a PR for it?

@kefran06
Copy link
Author

i'm pretty new to rust, I tried something maybe you can help me to tell me if I missed something

https://github.com/drogue-iot/embedded-tls/pull/141/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants