Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question about cartesian_position in observation and action_dict #2

Open
yangsizhe opened this issue Mar 21, 2024 · 6 comments
Open

Comments

@yangsizhe
Copy link

I appreciate the work you've done on this project. I have a question regarding the cartesian_position in the observation and action_dict. Which pose does this cartesian_position refer to? Is it the pose of the TCP (Tool Center Point), which is the position of the light green cube in the image, or is it the pose of the gripper frame (where the red line represents the X-axis and the green line represents the Y-axis)?

Additionally, I'm curious about how the base frame of the robot is defined. When I import joint state data into the simulator, I find that the position of the end effector differs from the position in the cartesian_position in the dataset by approximately [-0.36, -0.44, 0.10].

Thank you in advance!
gripper

@AlexanderKhazatsky
Copy link
Contributor

Hi, we experimented with many different grippers and to keep things consistent we use the wrist site of the robot rather that the actual gripper location. I believe that should explain the issue you're seeing. Let me know if you have any follow up questions!

@yangsizhe
Copy link
Author

Thank you for your explanation! I would like to know how to conveniently obtain the TCP pose through joint_position, gripper_position, and the gripper model. Do you have any recommended tools, such as corresponding models for hardware in simulator, to solve the TCP pose through forward kinematics?

@Nimolty
Copy link

Nimolty commented Apr 21, 2024

Dear authors,

I am writing to you to ask some questions about the action space in the paper "Droid".

I noticed that in the Github Issues, the author reminded that the action is the "wrist pose". However, I could hardly understand what does the wrist mean? I try to visualize the action pose but couldn't find the "wrist space origin and x,y,z-axis". I am trying to transform the original wrist action pose into the tcp action pose, so the accurate definition of wrist space is quite important.

I have attached a figure and could you please show the concrete definition of wrist space. I would appreciate it very much if you could solve my concerns.

@Nimolty
Copy link

Nimolty commented Apr 21, 2024

image.pdf

@AlexanderKhazatsky
Copy link
Contributor

The wrist site would correspond to the part of the gripper where the red and green lines are protruding. In other words, where it attached to the franka arm.

We've done some internal work a while back to work form the TCP site instead of the wrist site, and I've asked the person who led this effort to get back to you!

@AlexanderKhazatsky
Copy link
Contributor

To answer your question Nimolty, wrist site would be the spot between Link 7 and gripper mount in your diagram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants