Skip to content

Commit 61d8dde

Browse files
committed
Update tests
1 parent 3871eec commit 61d8dde

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

affectedmoduledetector/src/test/kotlin/com/dropbox/affectedmoduledetector/AffectedModuleDetectorIntegrationTest.kt

+6
Original file line numberDiff line numberDiff line change
@@ -112,6 +112,9 @@ class AffectedModuleDetectorIntegrationTest {
112112

113113
// THEN
114114
assertThat(result.output).contains(":sample-app:assembleDebugAndroidTest SKIPPED")
115+
assertThat(result.output).contains(":sample-core:mergeDexDebugAndroidTest SKIPPED")
116+
assertThat(result.output).contains(":sample-core:packageDebugAndroidTest SKIPPED")
117+
assertThat(result.output).contains(":sample-core:assembleDebugAndroidTest SKIPPED")
115118
assertThat(result.output).contains(":sample-core:assembleAndroidTest SKIPPED")
116119
assertThat(result.output).contains(":assembleAffectedAndroidTests SKIPPED")
117120
}
@@ -190,6 +193,9 @@ class AffectedModuleDetectorIntegrationTest {
190193

191194
// THEN
192195
assertThat(result.output).contains(":sample-app:assembleDebugAndroidTest SKIPPED")
196+
assertThat(result.output).doesNotContain(":sample-core:mergeDexDebugAndroidTest")
197+
assertThat(result.output).doesNotContain(":sample-core:packageDebugAndroidTest")
198+
assertThat(result.output).doesNotContain(":sample-core:assembleDebugAndroidTest")
193199
assertThat(result.output).doesNotContain(":sample-core:assembleAndroidTest")
194200
assertThat(result.output).contains(":assembleAffectedAndroidTests SKIPPED")
195201
}

sample/buildSrc/src/main/kotlin/com/dropbox/sample/tasks/AffectedTasksPlugin.kt

+2-3
Original file line numberDiff line numberDiff line change
@@ -53,16 +53,15 @@ class AffectedTasksPlugin : Plugin<Project> {
5353
private fun registerAffectedTestTask(
5454
taskName: String, testTask: String, testTaskBackup: String?,
5555
rootProject: Project
56-
): Task {
57-
val task = rootProject.tasks.register(taskName) { task ->
56+
) {
57+
rootProject.tasks.register(taskName) { task ->
5858
val paths = getAffectedPaths(testTask, testTaskBackup, rootProject)
5959
paths.forEach { path ->
6060
task.dependsOn(path)
6161
}
6262
task.enabled = paths.isNotEmpty()
6363
task.onlyIf { paths.isNotEmpty() }
6464
}
65-
return task.get()
6665
}
6766

6867
private fun getAffectedPaths(

0 commit comments

Comments
 (0)