Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropbox Client uses wrong httpclient which causes port exhaustion #324

Open
evolvedlight opened this issue Sep 15, 2022 · 1 comment · May be fixed by #325
Open

Dropbox Client uses wrong httpclient which causes port exhaustion #324

evolvedlight opened this issue Sep 15, 2022 · 1 comment · May be fixed by #325
Labels

Comments

@evolvedlight
Copy link

Describe the bug
When using the Dropbox client in high traffic multithreaded environment, it's possible to easily exhaust all connections

To Reproduce
In a loop, keep creating Dropbox Clients and performing a request. In the options object, pass in a HTTPClient.

Expected Behavior
HttpClient is used for all requests

Actual Behavior
Authentication code makes a new HttpClient each time

Versions

  • SDK latest, 6.31.0
  • Dotnet 6
  • Linux kubernetes

Additional context
It's also difficult to see what the recommended way is to reuse Dropbox clients - ie it's not very threadsafe but it's also bad to keep creating new Dropbox Clients

@evolvedlight evolvedlight linked a pull request Sep 15, 2022 that will close this issue
7 tasks
@greg-db
Copy link
Contributor

greg-db commented Sep 15, 2022

Thanks for the report and PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants