Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build process generate strange javascript #88

Open
cojack opened this issue Jan 15, 2019 · 0 comments
Open

Build process generate strange javascript #88

cojack opened this issue Jan 15, 2019 · 0 comments

Comments

@cojack
Copy link

cojack commented Jan 15, 2019

Hi,
First of all, thanks @drudge for your work, but there is a problem with this builder library, I was trying to use it with https://github.com/nestjs/passport but passed parameters up above to the OAuth2Strategy was only the values from super:

export class FacebookTokenStrategy extends PassportStrategy(Strategy) {
	constructor(private readonly authService: AuthService) {
		super({
			clientID: config.facebook.app_id, // this
			clientSecret: config.facebook.app_secret // and that
		});
	}

	async validate(accessToken: string, refreshToken: string, profile) {
		return profile;
	}
}

Without options from your constructor, so basically what I have done is just copy your code to my project and allowJs set to true in tsconfig.json and it starts working.

So basically, if you would like to spend additional effort on this library to improve build process or even make it better and rewrite it to typescript I will be glad.

Once again, thanks a lot for sharing your code.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant