New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ComponentCollector not actually checking validation #248

Open

joachim-n opened this issue Apr 16, 2022 · 1 comment

Contributor

joachim-n commented Apr 16, 2022

We call validate() but don't check the result, so it's useless!

Adding an assertion that violations are empty causes lots of test failures.

Contributor Author

joachim-n commented Jul 8, 2022

This won't validate internal properties! And using revealInternal() will complain about missing labels, which would be a PITA to add in everywhere!

Needs joachim-n/mutable-typed-data#7 to be fixed first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment