Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Backport type improvements as @* docblock annotations #1339

Open
Kingdutch opened this issue Apr 18, 2023 · 2 comments
Open

[4.x] Backport type improvements as @* docblock annotations #1339

Kingdutch opened this issue Apr 18, 2023 · 2 comments

Comments

@Kingdutch
Copy link
Contributor

Kingdutch commented Apr 18, 2023

We plan to make type improvements in [#1338]. We can't port those to 4.x because they'd be breaking changes and sometimes the normal docblock types interfere with PHPCS. However we can use @* docblock annotations to backport the types and make them show up for everyone using PHPStan. That will help people get their 4.x code ready for 5.x

@klausi
Copy link
Contributor

klausi commented Apr 18, 2023

Hm, I don't think we need @phpstan- docblocks in many cases, we should fix Coder/PHPCS to not contradict PHPStan. Most work on that is already done or in progress, for example https://www.drupal.org/project/coder/issues/3205017

@Kingdutch Kingdutch changed the title [4.x] Backport type improvements as @phpstan-* annotations [4.x] Backport type improvements as @* docblock annotations Apr 20, 2023
@Kingdutch
Copy link
Contributor Author

Yeah you're absolutely right! My mind still has to get used to the fact that coder now supports those syntaxes which awesome! 🎉 Adjusted the issue accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants