Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for bare repository is unreliable #106

Open
sammcj opened this issue Jun 6, 2018 · 0 comments
Open

Test for bare repository is unreliable #106

sammcj opened this issue Jun 6, 2018 · 0 comments

Comments

@sammcj
Copy link

sammcj commented Jun 6, 2018

This test for a bare repo is unreliable as it requires 'hooks' to strictly be of type 'file'.

In many environments, for example GitLab this test will fail because hooks is a symlink, not a 'file', its a symlink:

# file hooks
hooks: symbolic link to `/opt/gitlab/embedded/service/gitlab-shell/hooks'

I suggest changing the -f to -e so it works if 'hooks' exists as a file or symlink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant