Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatibility with Vagrant 1.1.x #17

Open
command-tab opened this issue Mar 15, 2013 · 14 comments
Open

Incompatibility with Vagrant 1.1.x #17

command-tab opened this issue Mar 15, 2013 · 14 comments

Comments

@command-tab
Copy link

The plugin format for Vagrant 1.1.x has changed, rendering vagrant-ansible broken. Are there plans to update it? If not, I might take a crack at it (even with my limited Ruby skills).

@mbadran
Copy link

mbadran commented Mar 17, 2013

+1

@cvitan
Copy link

cvitan commented Mar 18, 2013

+1

I have made an effort to port the plugin to 1.1 and it's really close to be finished. Unfortunately I have basically no Ruby knowledge, I have used the documentation and the other provisioning plugins as a base. If you would find it useful, I could at least make a pull req with what I have.

@command-tab
Copy link
Author

@cvitan I'd be interested in putting your code through its paces — I've got some Ansible scripts to work on and would like to continue using Vagrant 1.1 with VMware. I don't see it yet in your vagrant-ansible fork.

@cvitan
Copy link

cvitan commented Mar 18, 2013

@commandtab Sure, I'll just clean it up a bit and push it as soon as I have time, have made some further progress still.

@emckenna
Copy link

gem sub-command was also renamed, ('plugin' now?), So need new installation instructions as well.

@AlexMikhalev
Copy link

I got: Message: uninitialized constant Vagrant::Provisioners::Base after successful vagrant plugin install vagrant-ansible.
Is it large change to make ansimble plugin compatible with 1.1?

@command-tab
Copy link
Author

I wrote a new Vagrant plugin for 1.1.x that does most of what vagrant-ansible does:

hashicorp/vagrant#1465
https://github.com/hashicorp/docs.vagrantup.com/pull/10

The only thing it doesn't do is the temporary inventory file, because using it stops group_vars and host_vars from working, which are (more often than not) very important for playbooks. Looking for feedback :) Hopefully this will get pulled into Vagrant core.

@mbadran
Copy link

mbadran commented Mar 21, 2013

@commandtab Looks awesome! And merging it into Vagrant core is the way to go.

Please vote: hashicorp/vagrant#1465

@cvitan
Copy link

cvitan commented Mar 23, 2013

Well done! Maybe it would be a good idea to serve it as an installable plugin until then?

@garethrees
Copy link

Is this fixed by the release of hashicorp/vagrant#1465?

@dch
Copy link

dch commented Aug 27, 2013

@dsander maybe you can mention DEPRECATED in the repo title, or rename it, or something? As its now part of vagrant core, people finding this repo can lose lots of time wondering why it doesn't work...

Thanks for leading the way with this plugin!

@dsander
Copy link
Owner

dsander commented Aug 27, 2013

@dch thanks for the heads up. I updated the README, can you please confirm the documentation link is valid?

@milojennings
Copy link

oh my god, I just spent like hours, between several sessions of trying to figure out why Ansible was working on one machine and not on another. Turns out, adding this plugin actually breaks Vagrant 1.3+, since it's already built in. Now I feel stupid.

But perhaps someone can avoid the same fate as me.

@dch
Copy link

dch commented Sep 30, 2013

@dsander, perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants