From 0bbc42f9a3556290d61793916f88b1c62d02901b Mon Sep 17 00:00:00 2001 From: gdakate Date: Mon, 27 Mar 2023 11:33:31 +0900 Subject: [PATCH] =?UTF-8?q?[feat=20&=20refactor]=20=ED=8F=B4=EB=8D=94=20?= =?UTF-8?q?=EC=A1=B0=ED=9A=8C=EC=8B=9C=20=EA=B0=9D=EC=B2=B4=20=EB=B0=98?= =?UTF-8?q?=ED=99=98=20API=20with=20h2=20success=20#29?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../HighLight/Folder/FolderController.java | 8 ++++---- .../HighLight/Folder/FolderResponseDto.java | 13 ++++++++----- .../HighLight/Folder/FolderService.java | 11 ++++++----- .../HighLight/Folder/FolderViewResponseDto.java | 5 ++++- 4 files changed, 22 insertions(+), 15 deletions(-) diff --git a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderController.java b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderController.java index bd86be2..b3ac378 100644 --- a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderController.java +++ b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderController.java @@ -1,11 +1,11 @@ package com.SollutionChallenge.HighLight.Folder; -import org.springframework.beans.factory.annotation.Autowired; +import java.util.List; + import org.springframework.web.bind.annotation.GetMapping; import org.springframework.web.bind.annotation.PathVariable; import org.springframework.web.bind.annotation.PostMapping; import org.springframework.web.bind.annotation.RequestBody; -import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RestController; import com.SollutionChallenge.HighLight.common.ApiResponse; @@ -25,8 +25,8 @@ private ApiResponse createFolder(@RequestBody FolderRequestDto folderRequestDto) } @GetMapping("/folder") - private ApiResponse getFolder(){ - FolderViewResponseDto response = folderService.viewFolder(); + private ApiResponse> getFolder(){ + List response = folderService.viewFolder(); return ApiResponse.successCode(Success.GET_FOLDER_SUCCESS,response); } diff --git a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderResponseDto.java b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderResponseDto.java index 30b34e1..625acf7 100644 --- a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderResponseDto.java +++ b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderResponseDto.java @@ -1,9 +1,5 @@ package com.SollutionChallenge.HighLight.Folder; -import java.util.List; - -import com.SollutionChallenge.HighLight.User.User; - import lombok.AccessLevel; import lombok.Getter; import lombok.NoArgsConstructor; @@ -14,11 +10,18 @@ public class FolderResponseDto { private Long id; private String folderName; + public FolderResponseDto(Long id, String folderName) { + this.id = id; + this.folderName = folderName; + } + public static FolderResponseDto from(Long id, String folderName){ - FolderResponseDto folderResponseDto = new FolderResponseDto(); + FolderResponseDto folderResponseDto = new FolderResponseDto(id, folderName); folderResponseDto.id = id; folderResponseDto.folderName = folderName; return folderResponseDto; } + + } diff --git a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderService.java b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderService.java index 8b472b0..46fcdef 100644 --- a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderService.java +++ b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderService.java @@ -1,5 +1,6 @@ package com.SollutionChallenge.HighLight.Folder; +import java.util.ArrayList; import java.util.Collections; import java.util.List; import java.util.Optional; @@ -52,16 +53,16 @@ public FolderResponseDto save(FolderRequestDto folderRequestDto) { } - public FolderViewResponseDto viewFolder() { + public List viewFolder() { List folders = folderRepository.findAll(); - List folderNames = Collections.emptyList(); + List folderResponseDtos =new ArrayList<>(); if (folders != null && !folders.isEmpty()) { - folderNames = folders.stream() + folderResponseDtos = folders.stream() .filter(f -> f.getName() != null) - .map(Folder::getName) + .map(f-> new FolderResponseDto(f.getId(),f.getName())) .collect(Collectors.toList()); } - return FolderViewResponseDto.of(folderNames); + return folderResponseDtos; } public FolderResponseDto viewOneFolder(Long folder_id) { diff --git a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderViewResponseDto.java b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderViewResponseDto.java index 1a0729e..2bf2b8e 100644 --- a/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderViewResponseDto.java +++ b/src/main/java/com/SollutionChallenge/HighLight/Folder/FolderViewResponseDto.java @@ -9,11 +9,14 @@ @Getter @NoArgsConstructor(access = AccessLevel.PROTECTED) public class FolderViewResponseDto { + private List id; private List folderName; - public static FolderViewResponseDto of(ListfolderName){ + public static FolderViewResponseDto of(List id,ListfolderName){ FolderViewResponseDto folderViewResponseDto = new FolderViewResponseDto(); + folderViewResponseDto.id= id; folderViewResponseDto.folderName = folderName; + return folderViewResponseDto; } }