Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor version upgrade #2054

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Minor version upgrade #2054

wants to merge 11 commits into from

Conversation

DorBreger
Copy link

@DorBreger DorBreger commented Dec 20, 2024 •
edited by johlju
Loading

Pull Request (PR) description

Perform minor version upgrades too, as expected when setting the Action to Upgrade, and having a newer CU in the UpdateSource folder.
-->

This Pull Request (PR) fixes the following issue

Task list

  • [X ] Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • [ X] Resource documentation updated in the resource's README.md.
  • [ X] Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • [ X] Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@DorBreger DorBreger requested a review from a team as a code owner December 20, 2024 15:03
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 14.00000% with 43 lines in your changes missing coverage. Please review.

Project coverage is 93%. Comparing base (85ea1ed) to head (7ab71b2).

Files with missing lines Patch % Lines
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 14% 42 Missing ⚠️
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           main   #2054     +/-   ##
======================================
- Coverage    94%     93%     -2%     
======================================
  Files        94      36     -58     
  Lines      7930    6361   -1569     
======================================
- Hits       7500    5932   -1568     
+ Misses      430     429      -1
Flag Coverage Δ
unit 93% <14%> (-2%) ⬇️
Files with missing lines Coverage Δ
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1 96% <0%> (-1%) ⬇️
source/DSCResources/DSC_SqlSetup/DSC_SqlSetup.psm1 93% <14%> (-6%) ⬇️

... and 58 files with indirect coverage changes

@DorBreger DorBreger requested a review from johlju as a code owner December 21, 2024 10:30
@DorBreger
Copy link
Author

I will get down to fixing the failing tests next Saturday.

@DorBreger DorBreger marked this pull request as draft December 21, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johlju johlju Awaiting requested review from johlju johlju is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor version upgrade of already installed SQL Server instance
1 participant
@DorBreger