Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New-xDscResource: Change Resource Output File encoding to ASCII #81

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

New-xDscResource: Change Resource Output File encoding to ASCII #81

wants to merge 4 commits into from

Conversation

X-Guardian
Copy link
Contributor

@X-Guardian X-Guardian commented Sep 12, 2019 •
edited
Loading

Pull Request (PR) description

This PR changes the resource output files produced by the New-xDscResource function to use ASCII encoding instead of Unicode to conform to the Dsc style guidelines.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry under the Unreleased section of the change log in the README.md.
    Entry should say what was changed, and how that affects users (if applicable).
  • Documentation added/updated in README.md.
  • Comment-based help added/updated for all new/changed functions.
  • Localization strings added/updated in all localization files as appropriate.
  • Unit tests added/updated.
  • New/changed code adheres to
    DSC Resource Style Guidelines
    and Best Practices.

This change is Reviewable

@codecov-io
Copy link

codecov-io commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #81 into dev will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev      #81   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files           1        1           
  Lines         994      994           
  Branches        3        3           
=======================================
  Hits          609      609           
  Misses        382      382           
  Partials        3        3
Impacted Files Coverage Δ
xDSCResourceDesigner.psm1 61.26% <80%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492834e...49d088d. Read the comment docs.

@X-Guardian X-Guardian marked this pull request as ready for review September 12, 2019 21:40
@gaelcolas
Copy link
Member

This one looks good code-wise, but I'd need to run different tests on different version of PowerShell to be sure it works fine.
It should, but I vaguely remember some odd behaviours I want to avoid.

@johlju johlju added the needs review The pull request needs a code review. label Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review The pull request needs a code review.
Projects
None yet
Milestone
No milestone
4 participants
@X-Guardian @codecov-io @gaelcolas @johlju