Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added responsiveness to the sidebar #162

Closed
wants to merge 2 commits into from
Closed

Added responsiveness to the sidebar #162

wants to merge 2 commits into from

Conversation

ritwizsinha
Copy link
Contributor

@ritwizsinha ritwizsinha commented Jul 6, 2019

Fixes #155

Changes: Added responsiveness to sidebar

Surge Deployment Link: https://pr-162-sahaayak.surge.sh

Screenshots for the change: [Add here screenshots showing the changes.]

@harsh-jindal
Copy link
Member

@ritwizsinha I didn't get the issue.Attach a screenshot.
Remove console.log and comments from your code

@ritwizsinha
Copy link
Contributor Author

@harsh-jindal the issue was that the sidebar should close automatically when the screen size is reduced
to a particulaar size(but it doesn't) otherwise it doesn't look good , I have attached a screenshot of the problem in the issue itself

@harsh-jindal
Copy link
Member

@ritwizsinha Not required. The user is not going to change his view port. Close the issue and PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsivenes error
2 participants