Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added previous button in QuizView and toggleable radio #71

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ayyysh04
Copy link

@ayyysh04 ayyysh04 commented Dec 27, 2021

-Added previous button in QuizView
-Added toggleable radio in Quiz and removed the clearAll options button

@github-actions
Copy link

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@github-actions
Copy link

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@ayyysh04
Copy link
Author

-Added darkTheme
-Added theme_service.dart file in Services folder
-Edited theme.dart in utils folder
-Removed scroll glow from list view

Copy link
Member

@abhibhaw abhibhaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do add a few screenshots of the UI changes in the PR for reference.

aptiche/lib/views/quiz/quiz_controller.dart Show resolved Hide resolved
aptiche/lib/views/quiz/quiz_view.dart Show resolved Hide resolved
aptiche/lib/widgets/HomeScreen/drawer.dart Outdated Show resolved Hide resolved
fixed quizview themedata
@github-actions
Copy link

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@ayyysh04
Copy link
Author

ayyysh04 commented Dec 28, 2021

UI screenshots :

Home Page (Dark Mode) Quiz Page (Dark Mode) Drawer (Dark Mode) Home Page (Dark Mode) Home Page (Light Mode)

Copy link
Member

@SriramPatibanda SriramPatibanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR tries to add the previous button to the Quiz View, but you had also added dark mode here. Please create a separate PR for separate features as that would be helpful for us in the future. The colors used for dark mode don't make the app look that great I feel. You can choose a dark mode color pallette and comment in the issue and if it seems good, we'll approve and then you can work on it.

@github-actions
Copy link

github-actions bot commented Jan 2, 2022

image image
Hello @ayyysh04 , That's a great improvement to the code. Have a pinch of paitence while the reviewer gets impressed by the changes you made. Here are some doggos for company while you are waiting for the merge and marching ahead with your Hacktoberfest Contributions, Check your Dashboard for more information on Hacktoberfest. Stay safe 🚀 .

@ayyysh04
Copy link
Author

ayyysh04 commented Jan 2, 2022

This PR tries to add the previous button to the Quiz View, but you had also added dark mode here. Please create a separate PR for separate features as that would be helpful for us in the future. The colors used for dark mode don't make the app look that great I feel. You can choose a dark mode color pallette and comment in the issue and if it seems good, we'll approve and then you can work on it.

Done, sorry for the inconvenience

@ayyysh04 ayyysh04 requested a review from abhibhaw January 3, 2022 15:33
@nayakastha
Copy link
Member

nayakastha commented Feb 9, 2022

@ayyysh04 Can you please put the final screenshots of the changes, so that I can review and merge the changes asap
Please run flutter pub upgrade and make sure you remove the errors. There seems to be one in the file lib/widgets/snackbar.dart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request safe-for-build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a button to navigate to the previous question.
4 participants