Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback prettier to fix issue #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

404salad
Copy link

@404salad 404salad commented Oct 5, 2023

πŸ› οΈ Fixes Issue 104

Closes #104

πŸ‘¨β€πŸ’» Changes proposed

Rollback the prettier version to 3.3 which works until the new version is stable

πŸ”§ Check List (Check the type of issue it fixes)

  • [ βœ”οΈ] Bug Fix
  • New Extension
  • Enhancement
  • Documentation

βœ”οΈ Check List (Check all the applicable boxes)

  • [ βœ”οΈ] My code follows the code style of this project.
  • [ βœ”οΈ] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [ βœ”οΈ] My changes generate no new warnings
  • [βœ”οΈ ] Any dependent changes have been merged and published in downstream modules
  • [ βœ”οΈ] I have done git pull before adding my new changes
  • [βœ”οΈ ] The title of my pull request is a short description of the requested changes.

πŸ“„ Note to reviewers

The older version of prettier is stable so we can work with version 3.3 temporarily, i tested it and it works. When they release a stable fix, we can easily switch to that.

πŸ“· Screenshots

image

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
dscvitchennai βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 5, 2023 1:19pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions "prettier-action" throws error
1 participant