Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate magic numbers to enums #45

Open
PMeira opened this issue Aug 24, 2018 · 2 comments
Open

Migrate magic numbers to enums #45

PMeira opened this issue Aug 24, 2018 · 2 comments
Assignees
@PMeira
Milestone
pre-1.0

Comments

@PMeira
Copy link
Member

PMeira commented Aug 24, 2018

Many parameters which could use explicit Pascal enumeration types are currently using magic numbers. That includes most of the properties indices and many model parameters.

Since most of the official OpenDSS code is stable, besides the parallel machine and related changes, slowing changing those would make the code quality better. This can be done on a file-by-file basis.
@PMeira PMeira transferred this issue from dss-extensions/electricdss-src Mar 6, 2019
@PMeira
Copy link
Member Author

PMeira commented Apr 8, 2019

Example of issue that would be avoided:
21d0bdb

@PMeira
Copy link
Member Author

PMeira commented Jul 19, 2019

Working on this recently. As a subtask:

  • Enforce input values to match enums

@PMeira PMeira self-assigned this Jul 19, 2019
@PMeira PMeira mentioned this issue Dec 7, 2019
Open
5 tasks
@PMeira PMeira added this to the 0.11 milestone Jul 10, 2020
@PMeira PMeira modified the milestones: 0.11, 0.13 May 15, 2021
@PMeira PMeira mentioned this issue Jul 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PMeira PMeira

Labels
None yet
Projects
None yet
Milestone
pre-1.0
Development

No branches or pull requests
1 participant
@PMeira