You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
VCRURLConnection doesn’t properly record requests if they have the same method and same URL but different headers and/or body. This is obvious when looking at the source code since VCRRequestKey is based on the URI and method properties only.
An example where this behavior becomes problematic is when using the Range header. Say you first ask for range 0-123 then you ask for range 0-12345. The second request will never be recorded because it’s considered equal to the first one since it has the same URL and same method.
I plan to work on this issue but before I start I’d like to know what’s the status of #16 as these issues are slightly related.
The text was updated successfully, but these errors were encountered:
Thanks @0xced. Agree that VCRRequestKey should be expanded to differentiate between these requests.
I believe this work and #16 can move forward independently. This work makes VCRRequestKey a more precise mapping to a single recording while #16 maps a single VCRRequestKey to multiple recordings.
VCRURLConnection doesn’t properly record requests if they have the same method and same URL but different headers and/or body. This is obvious when looking at the source code since
VCRRequestKey
is based on theURI
andmethod
properties only.An example where this behavior becomes problematic is when using the
Range
header. Say you first ask for range 0-123 then you ask for range 0-12345. The second request will never be recorded because it’s considered equal to the first one since it has the same URL and same method.I plan to work on this issue but before I start I’d like to know what’s the status of #16 as these issues are slightly related.
The text was updated successfully, but these errors were encountered: