This repository has been archived by the owner on Mar 25, 2024. It is now read-only.
Deterministically destroy sign of NaN when converted to Number #394
+15
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
f32 as f64would produce a nondeterministic sign, as I found out in rust-lang/miri#3139. This would then get leaked byas_f64()or by serialization of theNumber. It doesn't make a difference when serializing to YAML, but we support serializingserde_yaml::Numberto TOML and other formats, where it does.YAML only has one NaN, so even negative NaNs serialize to
.nanin YAML. It seems fine to discard the original sign inserde_yaml::Numbertoo.