Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2PKH output are stakeable #997

Open
Gnappuraz opened this issue Apr 16, 2019 · 2 comments
Open

P2PKH output are stakeable #997

Gnappuraz opened this issue Apr 16, 2019 · 2 comments
Labels
bug A problem of existing functionality technical debt Cleaning up code which is there for historical reasons
Milestone
0.2

Comments

@Gnappuraz
Copy link
Member

Gnappuraz commented Apr 16, 2019 •
edited
Loading

Describe the bug
// UNIT-E TODO: Restrict to witness programs only once #212 is merged (fixes #48) hasn't been removed hence any P2PKH output is considered stakeable but once we try to sign a just created block we'll fail to ExtractP2WPKHKeys() cause the utxo is not a witness compatible one.

To Reproduce
Create a legacy address, send all the funds there, try to propose.

Expected behavior
We should not be able to stake coins that have a non-witness script.
@Gnappuraz Gnappuraz added the bug A problem of existing functionality label Apr 16, 2019
@thothd thothd added this to the 0.2 milestone Apr 16, 2019
@thothd thothd added technical debt Cleaning up code which is there for historical reasons bug A problem of existing functionality and removed bug A problem of existing functionality labels Apr 16, 2019
@Gnappuraz Gnappuraz mentioned this issue Apr 17, 2019
Closed
@castarco
Copy link

It seems that Github didn't close this issue automatically, but as far as I can see, it's already fixed.

@castarco
Copy link

Woops, it says "closed", nor "merged", reopening just in case.

@castarco castarco reopened this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem of existing functionality technical debt Cleaning up code which is there for historical reasons
Projects
None yet
Milestone
0.2
Development

Successfully merging a pull request may close this issue.

Stop node from using P2PKH outputs for staking
3 participants
@castarco @Gnappuraz @thothd