Do not expose bun CLI to the end user
#3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We silently expose a CLI to the bun executable on the user's PATH which could mess with its own existing bun setup. Instead, pybun now only exposes a CLI to the bun executable via `pybun`, `python -m pybun`, or a programmatic access. --- Fix #2
|
Hey @DetachHead ! I just made a quick change to avoid exposing a For now having two packages to maintain like njzjz/nodejs-wheel did seems a bit too much for me (but could be reconsidered eventually if needs be). Before I merge and release a patched version I will make another PR later this week to automate the release process of new pybun version like you suggested in #1. |
|
yeah this seems like a decent solution for now, thanks! |
DetachHead
approved these changes
Oct 7, 2024
|
Thanks for your time :) |
ducdetronquito
deleted the
task/do-not-expose-bun-cli-to-an-end-user-silently
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We silently expose a CLI to the bun executable on the user's PATH which could mess with its own existing bun setup.
Instead, pybun now only exposes a CLI to the bun executable via
pybun,python -m pybun, or a programmatic access.Fix #2