Skip to content

Latest commit

 

History

History
181 lines (121 loc) · 7.1 KB

help-developer-guide.md

File metadata and controls

181 lines (121 loc) · 7.1 KB

Developer Guide

Writing documentation

You contributions to the October documentation are very welcome. Please follow the next rules if you want to contribute. How to style perfect October documentation pages:

  • Each page that has at least one H2 header should have a TOC list. The TOC list should be the first element after the H1 header. The TOC should have links to all H2 headers on the page.
  • There should be an introductory text below the TOC, even if there is the Introduction section. You may want to get rid of the Introduction section if it's not really needed. Don't leave the TOC alone.
  • Try to use only H2 and H3 headers.
  • Each H2 and H3 header should have a link defined as
<a name="page-cycle-handlers" class="anchor" href="#page-cycle-handlers"></a>
  • Avoid short, 1 sentence, paragraphs. Merge short paragraphs and try to be a bit more verbose.
  • Avoid short hanging paragraphs below code sections. Merge such paragraphs with the text above the code blocks.
  • Use the inline code tags for everything related to code - variable names, function names, syntax examples, etc.
  • Use the strong tag for everything else.
  • Don't hesitate to make cross links to other documentation articles. Adding links to the same article in the same paragraph is not necessary.
  • See the cms-pages.md or cms-themes.md files for your reference.

Developer Standards and Patterns

This section describes some standards that we highly recommend to follow for everybody, especially if you are going to publish your products on the Marketplace.

Repository naming

Plugins to be named with the -plugin suffix and optional oc- prefix.

blog-plugin
oc-blog-plugin

Themes to be named with the -theme suffix and optional oc- prefix.

happy-theme
oc-happy-theme

PHP Variable naming

Use camelCase everywhere except for the following:

  • Postback parameters should use snake_case
  • Database columns should use snake_case
  • Language keys should use snake_case

HTML element naming

[Form] Element names should use snake_case (underscores)

<input name="first_name" />

Where the name is an array, the array keys can be either StudlyCase or snake_case.

<input name="ForumMember[first_name]" />
<input name="forum_member[first_name]" />

Element IDs should be camel case or hyphen-case (dashes)

<div id="firstNameGroup">
    <input id="firstName" />
</div>

<div id="first-name-group">
    <input id="first-name" />
</div>

Element classes names should use hyphen-case (dashes)

<div class="form-group">
    <input class="form-control" />
</div>

View file naming

Partial views should begin with an underscore character. Whereas Controller and Layout views do not begin with an underscore character. Since views are often found in a single folder, the underscore (_) and dash (-) characters can be used to organise the files. A dash is used as a substitute for a space character. An underscore is used as a substitute for a slash character (folder or namespace).

index_fancy-layout.htm       <== Index\Fancy layout
form-with-sidebar.htm        <== Form with sidebar
_field-container.htm         <== Field container (partial)
_field_baloon-selector.htm   <== Field\Baloon Selector (partial)

View files must end with the .htm file extension but .html is also accepted (todo).

Class naming

There is a number of class suffixes and prefixes that we recommend to use.

Don't get naming paralysis. Yes, names are very important but they're not important enough to waste huge amounts of time on. If you can't think up a good name in five minutes, move on.

  • Manager
  • Builder
  • Writer
  • Reader
  • Handler
  • Container
  • Protocol
  • Target
  • Converter
  • Controller
  • View
  • Factory
  • Entity
  • Bag

Event naming

The term after is not used in Events, only the term before is used. For example:

  • beforeSetAttribute - this event comes before any default logic.
  • setAttribute - this event comes after any default logic.

Where possible events should cover global and local versions. Global events should be prefixed with the module or plugin name. For example:

// For global events, it is prefixed with the module or plugin code
Event::fire('cms.page.end')

// For local events, the prefix is not required
$this->fireEvent('page.end')

Avoid using terms such as onSomething in event names since the word bind/fire represent this action word.

It is good practise to always pass the calling object as the first parameter to the global event. The local event should not need this.

// Local event
if ($this->fireEvent('beforeAddContent', [$message, $view], true) === false)
    return;

// Global event
if (Event::fire('mailer.beforeAddContent', [$this, $message, $view], true) === false)
    return;

When expecting results, it is easy to combine the arrays like so:

// Combine local and global event results
$eventResults = $this->fireEvent('form.beforeRefresh', [$saveData]) + Event::fire('backend.form.beforeRefresh', [$this, $saveData]);

Database table naming

Tables names should be prefixed with the author and plugin name.

acme_blog_xxx

Boolean column names should be prefixed with is_

is_activated
is_visible

This is because the model attributes can conflict, for example, public $visible; in the Model class conflicts with a database column with the same name. Some column names are exceptions, for example notify_user.

Model naming

When extending other models, you should prefix the field with at least the plugin name.

User::extend(function($model) {
    $model->hasOne['forum_member'] = ['RainLab\Forum\Models\Member'];
});

The fully qualified plugin name is also acceptable, for example:

$user->rainlab_forum_member

Use the STRICT_TRANS_TABLES mode with MySQL

When MySQL STRICT_TRANS_TABLES mode is enabled the server performs strict data type validation. It is highly recommended to keep this mode enabled in MySQL during the development. This allows to find errors before your code gets to a client's server with the enabled strict mode. The mode can be enabled in my.cnf (Unix) or my.ini (Windows) file:

sql_mode=STRICT_TRANS_TABLES