Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delta_scan cannot read from delta tables starting with uppercase letter. #7

Closed
mrjsj opened this issue May 23, 2024 · 4 comments
Closed

Comments

@mrjsj
Copy link

mrjsj commented May 23, 2024

Platform: MacOS ARM64

DuckDB version: 0.10.3

Trying to read a delta tabel with capital letter results in error:

D select * from delta_scan('file:///Users/jsj/Downloads/Pipelines');
IO Error: Hit DeltaKernel FFI error (from: snapshot in DeltaScanScanBind): Hit error: 15 (MissingVersionError) with message (No table version found.)

It works fine with the following delta table names:

  • pipelines
  • pIpelines (uppercase I after first p)
  • pipelineS (uppercase S)
  • pIPELINES (all capital except first p)
@mrjsj
Copy link
Author

mrjsj commented May 23, 2024

Update:

It works if I put a slash after the table name, e.g.

select * from delta_scan('file:///Users/jsj/Downloads/Pipelines/');

I have tried making the unit tests fail in delta-kernel-rs by making the the delta tables upper-case, but no issue there (or I'm not proficient enough in Rust).

For the record - the name of the delta table itself (on disk) doesn't matter, but if the delta table specified in the query is capitalized it fails.

@samansmink
Copy link
Collaborator

Im suspecting this to be a duplicate of #17 meaning that this is also fixed by #20.

The problem is that delta-kernel-rs needs paths to end in a / otherwise weird stuff happens. Now DuckDB will internally make sure that the paths passed to kernel are always ending in a /

@mrjsj
Copy link
Author

mrjsj commented May 29, 2024

Great, thank you!

@samansmink
Copy link
Collaborator

Should be fixed now, please let me know if it isn't!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants