Merge pull request #157 from ak2k/fix/sqlite-insert-cast

Mytherin · web-flow · commit 833e105cbcaa · 2025-09-02T22:01:04.000+02:00
Fix SQLiteInsert to use casted plan instead of raw plan
diff --git a/src/storage/sqlite_insert.cpp b/src/storage/sqlite_insert.cpp
@@ -192,7 +192,7 @@ PhysicalOperator &SQLiteCatalog::PlanInsert(ClientContext &context, PhysicalPlan
 	D_ASSERT(plan);
 	auto &inner_plan = AddCastToSQLiteTypes(context, planner, *plan);
 	auto &insert = planner.Make<SQLiteInsert>(op, op.table, op.column_index_map);
-	insert.children.push_back(*plan);
+	insert.children.push_back(inner_plan);
 	return insert;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ PhysicalOperator &SQLiteCatalog::PlanInsert(ClientContext &context, PhysicalPlan`
`192`	`192`	`D_ASSERT(plan);`
`193`	`193`	`auto &inner_plan = AddCastToSQLiteTypes(context, planner, *plan);`
`194`	`194`	`auto &insert = planner.Make<SQLiteInsert>(op, op.table, op.column_index_map);`
`195`		`- insert.children.push_back(*plan);`
	`195`	`+ insert.children.push_back(inner_plan);`
`196`	`196`	`return insert;`
`197`	`197`	`}`
`198`	`198`