Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make target serve_local is broken because of missing build_loadable_unsigned #1663

Open
isaacbrodsky opened this issue Mar 11, 2024 · 2 comments

Comments

@isaacbrodsky
Copy link
Contributor

isaacbrodsky commented Mar 11, 2024

What happens?

Make target serve_local depends on build_loadable_unsigned which is now missing, so this make target cannot be run.

I was looking for something like this because I was trying to run duckdb-wasm with extension signing off, as this is needed to test locally built extensions. (see also isaacbrodsky/h3-duckdb#71)

To Reproduce

make serve_local

Browser/Environment:

NA

Device:

NA

DuckDB-Wasm Version:

main

DuckDB-Wasm Deployment:

NA

Full Name:

NA

Affiliation:

NA

@jcolot
Copy link
Contributor

jcolot commented Apr 9, 2024

@isaacbrodsky I think it's closed, the build_loadable_unsigned target is now an alias of build_loadable but unsigned extensions can be loaded by using a DuckDBConfig object parameter for db.open(), after instantiation like this:

await db.instantiate(DUCKDB_CONFIG.mainModule, DUCKDB_CONFIG.pthreadWorker);
await db.open({allowUnsignedExtensions: true});

@jcolot
Copy link
Contributor

jcolot commented Apr 15, 2024

@isaacbrodsky I made an Observable notebook loading your extension h3ext

Observable notebook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants