Add wasm builds #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samansmink
reviewed
Nov 13, 2024
carlopi
force-pushed
the
fix_wasm_builds
branch
from
59a42bc to
a0bb145
Compare
samansmink
reviewed
Nov 13, 2024
carlopi
force-pushed
the
fix_wasm_builds
branch
from
48517b4 to
5e81c30
Compare
|
Thanks for the various input, now moving to lastest branch of extension-ci-tools, where in duckdb/extension-ci-tools#105 and duckdb/extension-ci-tools#106 the main part was done. |
|
gogogo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might require another round of polishing, and possible some more refactoring to move stuff to
extension-ci-tools.This is on top of #1, I would say that can be checked independently.
One problem I bumped against is that seemingly you can't feature-select the crate type, and that needs to be
staticlibfor wasm andcdylibfor native.Trick I copied from https://github.com/linebender/xilem/blob/6af19494cd985e6ac2e914e73d701fe78752a3fc/xilem/Cargo.toml#L40 is having a
[[example]]target, that has the right specifications for Wasm but has the same name and code.It's an hack, probably I should add a comment to src/wasm_lib.rs documenting this.