From 1e4d17254204fae8a8c9475bc078d67b38ac16cc Mon Sep 17 00:00:00 2001 From: Josh Leibstein Date: Tue, 20 Aug 2024 20:13:52 +0100 Subject: [PATCH] Fix fire button ripple (#4922) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Task/Issue URL: https://app.asana.com/0/488551667048375/1208089433074776/f ### Description Fixes the ripple on the fire button which clipped on the left side. ### Steps to test this PR - [x] Tap and hold the fire button - [x] Verify that the ripple isn’t clipped ### UI changes | Before | After | | ------ | ----- | ![Screenshot_20240820_185353](https://github.com/user-attachments/assets/7b528234-558d-4b1c-98a4-2ab1623794a4)|![Screenshot_20240820_184445](https://github.com/user-attachments/assets/a8c17c1b-a758-4341-b1e3-1199762cdd3d) --- app/src/main/res/layout/include_omnibar_toolbar.xml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/src/main/res/layout/include_omnibar_toolbar.xml b/app/src/main/res/layout/include_omnibar_toolbar.xml index 8f713fff0c31..cdbc57fa91cd 100644 --- a/app/src/main/res/layout/include_omnibar_toolbar.xml +++ b/app/src/main/res/layout/include_omnibar_toolbar.xml @@ -59,7 +59,10 @@ android:id="@+id/omniBarContainer" android:layout_width="match_parent" android:layout_height="match_parent" - android:layout_margin="8dp" + android:layout_marginStart="8dp" + android:layout_marginEnd="4dp" + android:layout_marginTop="8dp" + android:layout_marginBottom="8dp" android:paddingEnd="6dp" android:background="@drawable/omnibar_field_selector"> @@ -242,7 +245,7 @@ android:id="@+id/fireIconMenu" android:layout_width="wrap_content" android:layout_height="match_parent" - android:paddingStart="4dp" + android:paddingStart="8dp" android:paddingEnd="4dp" app:layout_constraintBottom_toBottomOf="parent" app:layout_constraintEnd_toStartOf="@id/tabsMenu"