You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improve search logic in feature inventory screen (#5232)
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208633884628758/f
### Description
Improve the (internal) feature flag inventory screen search logic:
Before:
* searches would filter feature flags that match the search text
After:
* searches filter feature flags that match the search text, but:
* if match is a top-level features, all sub-features are also considered a match (even if their name doesn't match)
* if match is a sub-feature, parent feature is also considered a match (even if its name doesn't match)
### Steps to test this PR
_Test_
- [x] install from this branch, open app -> settings -> feature flag inventory
- [x] search for a sub-feature by name
- [x] verify sub-feature and its parent top-level feature are displayed
- [x] search for a top-level feature by name (eg. autofill)
- [x] verify the top-level feature and ALL its sub-features are displayed
- [x] smoke test enable/disable features
Copy file name to clipboardExpand all lines: feature-toggles/feature-toggles-internal/src/main/java/com/duckduckgo/examplefeature/internal/ui/FeatureToggleInventoryActivity.kt
+29-11Lines changed: 29 additions & 11 deletions
Original file line number
Diff line number
Diff line change
@@ -117,25 +117,43 @@ class FeatureToggleInventoryActivity : DuckDuckGoActivity() {
0 commit comments