-
Notifications
You must be signed in to change notification settings - Fork 921
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve search logic in feature inventory screen (#5232)
Task/Issue URL: https://app.asana.com/0/1198194956794324/1208633884628758/f ### Description Improve the (internal) feature flag inventory screen search logic: Before: * searches would filter feature flags that match the search text After: * searches filter feature flags that match the search text, but: * if match is a top-level features, all sub-features are also considered a match (even if their name doesn't match) * if match is a sub-feature, parent feature is also considered a match (even if its name doesn't match) ### Steps to test this PR _Test_ - [x] install from this branch, open app -> settings -> feature flag inventory - [x] search for a sub-feature by name - [x] verify sub-feature and its parent top-level feature are displayed - [x] search for a top-level feature by name (eg. autofill) - [x] verify the top-level feature and ALL its sub-features are displayed - [x] smoke test enable/disable features
- Loading branch information
Showing
2 changed files
with
40 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters