Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Improvement] ReLinker library is redundant #5085

Closed
yasincidem opened this issue Sep 27, 2024 · 0 comments
Closed

[Code Improvement] ReLinker library is redundant #5085

yasincidem opened this issue Sep 27, 2024 · 0 comments

Comments

@yasincidem
Copy link

Describe the bug

ReLinker appears to be unnecessary

According to ReLinker's documentation:

If your app includes native libraries, and your minimum SDK is below API 23 (Marshmallow), you need ReLinker.

There are a number of different bugs addressed by ReLinker; the last of these was resolved as of Marshmallow. As long as your app's min SDK is at or above it, loading libraries via System.loadLibrary("foo") is safe.

Since this project's minimum SDK is API 26, it seems safe to remove ReLinker.

Does ReLinker still solve a problem in this codebase?

Relevant code references:
LibraryLoader.kt Line 26
LibraryLoader.kt Line 30

How to Reproduce

Expected behavior

Environment

No response

@yasincidem yasincidem closed this as not planned Won't fix, can't repro, duplicate, stale Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant