From f76fd96ab56e7e68228163b6950a88a8b2c19ab2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Gonz=C3=A1lez?= Date: Wed, 18 Dec 2024 21:45:23 +0100 Subject: [PATCH 1/3] GHA: Improve PR review notifications --- .../workflows/pr-review-notifications.yaml | 6 +- .../values-night/design-system-theming.xml | 2 + vpn_item_patch.patch | 175 ++++++++++++++++++ 3 files changed, 180 insertions(+), 3 deletions(-) create mode 100644 vpn_item_patch.patch diff --git a/.github/workflows/pr-review-notifications.yaml b/.github/workflows/pr-review-notifications.yaml index fc2c2b9d745c..406495034b5b 100644 --- a/.github/workflows/pr-review-notifications.yaml +++ b/.github/workflows/pr-review-notifications.yaml @@ -1,4 +1,4 @@ -name: Pull Request Reviewed -> Asana Sync +name: Pull Request Reviewed -> Sync With Asana on: pull_request_review: @@ -6,8 +6,8 @@ on: jobs: pr-reviewed: - name: Update Asana task -> PR reviewed - uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@david/improve-pr-notifications + name: Add PR reviewed comment + uses: duckduckgo/native-github-asana-sync/.github/workflows/pr-review-notifications.yml@v1.4 with: trigger-phrase: "Task/Issue URL:" secrets: diff --git a/common/common-ui/src/main/res/values-night/design-system-theming.xml b/common/common-ui/src/main/res/values-night/design-system-theming.xml index 4350821f20d8..a9aaa060591b 100644 --- a/common/common-ui/src/main/res/values-night/design-system-theming.xml +++ b/common/common-ui/src/main/res/values-night/design-system-theming.xml @@ -15,6 +15,8 @@ --> + +