From d128809276976fc08ed3fea150c93e4fdc3a1914 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mariusz=20=C5=9Apiewak?= Date: Mon, 28 Oct 2024 16:44:43 +0100 Subject: [PATCH 1/2] Add adAttributionReporting feature with subfeatures --- .../PrivacyConfig/Features/PrivacyFeature.swift | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift b/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift index 478aa8c4a..e9513579d 100644 --- a/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift +++ b/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift @@ -63,6 +63,7 @@ public enum PrivacyFeature: String { case networkProtection case aiChat case contextualOnboarding + case adAttributionReporting } /// An abstraction to be implemented by any "subfeature" of a given `PrivacyConfiguration` feature. @@ -183,3 +184,8 @@ public enum SyncPromotionSubfeature: String, PrivacySubfeature { case bookmarks case passwords } + +public enum AdAttributionReportingSubfeature: String, PrivacySubfeature { + public var parent: PrivacyFeature { .adAttributionReporting } + case includeToken +} From b5dbf3ca896df0482cf7d74c5b9ca76691416cf5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mariusz=20=C5=9Apiewak?= Date: Wed, 30 Oct 2024 14:35:32 +0100 Subject: [PATCH 2/2] Use setting instead of subfeature for adding token to parameters --- .../PrivacyConfig/Features/PrivacyFeature.swift | 5 ----- 1 file changed, 5 deletions(-) diff --git a/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift b/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift index e9513579d..64432522b 100644 --- a/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift +++ b/Sources/BrowserServicesKit/PrivacyConfig/Features/PrivacyFeature.swift @@ -184,8 +184,3 @@ public enum SyncPromotionSubfeature: String, PrivacySubfeature { case bookmarks case passwords } - -public enum AdAttributionReportingSubfeature: String, PrivacySubfeature { - public var parent: PrivacyFeature { .adAttributionReporting } - case includeToken -}