Mattermost improvements (#20)

lib/fastlane/plugin/ddg_apple_automation/assets/mattermost_send_message/templates/notarized-build-complete.txt.erb

@@ -1 +1 @@
-Notarized macOS app `<%= release_type %>` build is ready :goose_honk_tada: | [:github: Workflow run summary](<%= workflow_url %>)<% if defined?(asana_task_url) %> | [:asana: Asana Task](<%= asana_task_url %>)<% end %>
+Notarized macOS app `<%= release_type %>` build is ready :goose_honk_tada: | [:github: Workflow run summary](<%= workflow_url %>)<% if defined?(asana_task_url) && !asana_task_url.to_s.strip.empty? %> | [:asana: Asana Task](<%= asana_task_url %>)<% end %>

lib/fastlane/plugin/ddg_apple_automation/assets/mattermost_send_message/templates/notarized-build-failed.txt.erb

@@ -1 +1 @@
-:rotating_light: Notarized macOS app `<%= release_type %>` build failed | [:github: Workflow run summary](<%= workflow_url %>)<% if defined?(asana_task_url) %> | [:asana: Asana Task](<%= asana_task_url %>)<% end %>
+:rotating_light: Notarized macOS app `<%= release_type %>` build failed | [:github: Workflow run summary](<%= workflow_url %>)<% if defined?(asana_task_url) && !asana_task_url.to_s.strip.empty? %> | [:asana: Asana Task](<%= asana_task_url %>)<% end %>

lib/fastlane/plugin/ddg_apple_automation/assets/mattermost_send_message/templates/public-release-complete.txt.erb

@@ -1 +1 @@
-<%= app_platform %> app has been successfully uploaded to <%= destination %> :goose_honk_tada: | [:github: Workflow run summary](<%= workflow_url %>)
+<%= platform %> app has been successfully uploaded to <%= destination %> :goose_honk_tada: | [:github: Workflow run summary](<%= workflow_url %>)

lib/fastlane/plugin/ddg_apple_automation/assets/mattermost_send_message/templates/public-release-failed.txt.erb

@@ -1 +1 @@
-:rotating_light: macOS app <%= destination %> workflow failed | [:github: Workflow run summary](<%= workflow_url %>)
+:rotating_light: <%= platform %> app <%= destination %> workflow failed | [:github: Workflow run summary](<%= workflow_url %>)

lib/fastlane/plugin/ddg_apple_automation/version.rb

@@ -1,5 +1,5 @@
 module Fastlane
   module DdgAppleAutomation
-    VERSION = "0.11.6"
+    VERSION = "0.11.7"
   end
 end

spec/mattermost_send_message_action_spec.rb

@@ -75,6 +75,26 @@
       })).to eq(expected)
     end
 
+    it "processes notarized-build-complete template with a nil asana_task_url" do
+      expected = "Notarized macOS app `release` build is ready :goose_honk_tada: | [:github: Workflow run summary](https://workflow.com)"
+
+      expect(process_template("notarized-build-complete", {
+        "release_type" => "release",
+        "workflow_url" => "https://workflow.com",
+        "asana_task_url" => nil
+      })).to eq(expected)
+    end
+
+    it "processes notarized-build-complete template with an empty asana_task_url" do
+      expected = "Notarized macOS app `release` build is ready :goose_honk_tada: | [:github: Workflow run summary](https://workflow.com)"
+
+      expect(process_template("notarized-build-complete", {
+        "release_type" => "release",
+        "workflow_url" => "https://workflow.com",
+        "asana_task_url" => ""
+      })).to eq(expected)
+    end
+
     it "processes notarized-build-complete template with Asana task URL" do
       expected = "Notarized macOS app `release` build is ready :goose_honk_tada: | [:github: Workflow run summary](https://workflow.com) | [:asana: Asana Task](https://asana.com)"
 
@@ -108,7 +128,7 @@
       expected = "macOS app has been successfully uploaded to testflight :goose_honk_tada: | [:github: Workflow run summary](https://workflow.com)"
 
       expect(process_template("public-release-complete", {
-        "app_platform" => "macOS",
+        "platform" => "macOS",
         "destination" => "testflight",
         "workflow_url" => "https://workflow.com"
       })).to eq(expected)
@@ -118,6 +138,7 @@
       expected = ":rotating_light: macOS app testflight workflow failed | [:github: Workflow run summary](https://workflow.com)"
 
       expect(process_template("public-release-failed", {
+        "platform" => "macOS",
         "destination" => "testflight",
         "workflow_url" => "https://workflow.com"
       })).to eq(expected)