From 7c24cea75c4f8cb9b41a0c1785a6a522ecd94e8c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Thu, 5 Sep 2024 21:04:07 +0200
Subject: [PATCH 01/10] Add asana log message action

---
 .../actions/asana_add_comment_action.rb       | 16 ++--
 .../actions/asana_log_message_action.rb       | 90 +++++++++++++++++++
 .../helper/ddg_apple_automation_helper.rb     |  6 ++
 spec/asana_add_comment_spec.rb                |  8 +-
 4 files changed, 108 insertions(+), 12 deletions(-)
 create mode 100644 lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
index d2698ad..411a940 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
@@ -13,10 +13,9 @@ def self.run(params)
         task_url = params[:task_url]
         template_name = params[:template_name]
         comment = params[:comment]
-        workflow_url = params[:workflow_url]
 
         begin
-          validate_params(task_id, task_url, comment, template_name, workflow_url)
+          validate_params(task_id, task_url, comment, template_name)
         rescue ArgumentError => e
           UI.user_error!(e.message)
           return
@@ -25,10 +24,11 @@ def self.run(params)
         task_id = Fastlane::Actions::AsanaExtractTaskIdAction.run(task_url: task_url) if task_url
 
         if template_name.to_s.empty?
-          text = "#{comment}\n\nWorkflow URL: #{workflow_url}"
+          text = "#{comment}\n\nWorkflow URL: #{ENV.fetch('WORKFLOW_URL')}"
           create_story(asana_access_token, task_id, text: text)
         else
-          template_content = load_template_file(template_name)
+          template_file = Helper::DdgAppleAutomationHelper.path_for_asset_file("asana_add_comment/templates/#{template_name}.html")
+          template_content = Helper::DdgAppleAutomationHelper.load_template_file(template_file)
           return unless template_content
 
           html_text = process_template_content(template_content)
@@ -71,10 +71,6 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :template_name,
                                        description: "Name of a template file (without extension) for the comment. Templates can be found in assets/asana_add_comment/templates subdirectory.
       The file is processed before being sent to Asana",
-                                       optional: true,
-                                       type: String),
-          FastlaneCore::ConfigItem.new(key: :workflow_url,
-                                       description: "Workflow URL to include in the comment",
                                        optional: true,
                                        type: String)
         ]
@@ -84,7 +80,7 @@ def self.is_supported?(platform)
         true
       end
 
-      def self.validate_params(task_id, task_url, comment, template_name, workflow_url)
+      def self.validate_params(task_id, task_url, comment, template_name)
         if task_id.to_s.empty? && task_url.to_s.empty?
           raise ArgumentError, "Both task_id and task_url cannot be empty. At least one must be provided."
         end
@@ -93,7 +89,7 @@ def self.validate_params(task_id, task_url, comment, template_name, workflow_url
           raise ArgumentError, "Both comment and template_name cannot be empty. At least one must be provided."
         end
 
-        if comment && workflow_url.to_s.empty?
+        if comment && ENV.fetch('WORKFLOW_URL').to_s.empty?
           raise ArgumentError, "If comment is provided, workflow_url cannot be empty"
         end
       end
diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
new file mode 100644
index 0000000..6bec361
--- /dev/null
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -0,0 +1,90 @@
+require "fastlane/action"
+require "fastlane_core/configuration/config_item"
+require "asana"
+require_relative "../helper/ddg_apple_automation_helper"
+require_relative "asana_add_comment_action"
+require_relative "asana_get_release_automation_subtask_id_action"
+require_relative "asana_get_user_id_for_github_handle_action"
+
+module Fastlane
+  module Actions
+    class AsanaLogMessageAction < Action
+      def self.run(params)
+        asana_access_token = params[:asana_access_token]
+        task_url = params[:task_url]
+        template_name = params[:template_name]
+        comment = params[:comment]
+        is_scheduled_release = params[:is_scheduled_release] || true
+        github_handle = params[:github_handle]
+
+        automation_subtask_id = AsanaGetReleaseAutomationSubtaskIdAction.run(task_url: task_url, asana_access_token: token)
+
+        if is_scheduled_release
+          task_id = AsanaExtractTaskIdAction.run(task_url: task_url)
+          assignee_id = AsanaExtractTaskAssigneeAction.run(task_id: task_id, asana_access_token: token)
+        else
+          assignee_id = AsanaGetUserIdForGithubHandleAction.run(github_handle: github_handle, asana_access_token: token)
+        end
+
+        asana_client = Asana::Client.new do |c|
+          c.authentication(:access_token, asana_access_token)
+        end
+
+        begin
+          asana_client.tasks.add_followers_for_task(task_gid: task_id, followers: [assignee_id])
+        rescue StandardError => e
+          UI.user_error!("Failed to add a collaborator to the release task: #{e}")
+        end
+
+        AsanaAddCommentAction.run(task_id: automation_subtask_id, comment: comment, template_name: template_name, asana_access_token: token)
+      end
+
+      def self.description
+        "Add a Message to Asana Release Automation Task"
+      end
+
+      def self.authors
+        ["DuckDuckGo"]
+      end
+
+      def self.return_value
+        ""
+      end
+
+      def self.details
+        "Adds a comment about release progress to the Asana release task's 'Automation' subtask"
+      end
+
+      def self.available_options
+        [
+          FastlaneCore::ConfigItem.asana_access_token,
+          FastlaneCore::ConfigItem.new(key: :task_url,
+                                       description: "Asana release task URL",
+                                       optional: false,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :comment,
+                                       description: "Comment to add to the Asana task",
+                                       optional: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :template_name,
+                                       description: "Name of a template file (without extension) for the comment. Templates can be found in assets/asana_add_comment/templates subdirectory.
+      The file is processed before being sent to Asana",
+                                       optional: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :github_handle,
+                                       description: "Github user handle",
+                                       optional: true,
+                                       type: String),
+          FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
+                                       description: "Indicates whether the release was scheduled or started manually",
+                                       optional: true,
+                                       type: Boolean)
+        ]
+      end
+
+      def self.is_supported?(platform)
+        true
+      end
+    end
+  end
+end
diff --git a/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb b/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb
index d0f8320..8cf00f7 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/helper/ddg_apple_automation_helper.rb
@@ -22,6 +22,12 @@ def self.asana_task_url(task_id)
       def self.path_for_asset_file(file)
         File.expand_path("../assets/#{file}", __dir__)
       end
+
+      def self.load_template_file(template_file)
+        File.read(template_file)
+      rescue StandardError
+        UI.user_error!("Error: The file '#{template_file}' does not exist.")
+      end
     end
   end
 end
diff --git a/spec/asana_add_comment_spec.rb b/spec/asana_add_comment_spec.rb
index 3bc8a48..ad73522 100644
--- a/spec/asana_add_comment_spec.rb
+++ b/spec/asana_add_comment_spec.rb
@@ -36,8 +36,12 @@
     end
 
     it "shows error if comment is provided but workflow_url is not" do
-      expect(Fastlane::UI).to receive(:user_error!).with("If comment is provided, workflow_url cannot be empty")
-      test_action(task_id: "123", comment: "comment")
+      ClimateControl.modify(
+        WORKFLOW_URL: ''
+      ) do
+        expect(Fastlane::UI).to receive(:user_error!).with("If comment is provided, workflow_url cannot be empty")
+        test_action(task_id: "123", comment: "comment")
+      end
     end
 
     it "shows error if provided template does not exist" do

From 91ae0b60ae3a0e6d762dda64115536e0e81b3979 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Thu, 5 Sep 2024 22:37:19 +0200
Subject: [PATCH 02/10] Add spec

---
 .../actions/asana_log_message_action.rb       |  8 ++-
 spec/asana_log_message_spec.rb                | 71 +++++++++++++++++++
 2 files changed, 76 insertions(+), 3 deletions(-)
 create mode 100644 spec/asana_log_message_spec.rb

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
index 6bec361..06ccd5f 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -5,16 +5,18 @@
 require_relative "asana_add_comment_action"
 require_relative "asana_get_release_automation_subtask_id_action"
 require_relative "asana_get_user_id_for_github_handle_action"
+require_relative "asana_extract_task_id_action"
+require_relative "asana_extract_task_assignee_action"
 
 module Fastlane
   module Actions
     class AsanaLogMessageAction < Action
       def self.run(params)
-        asana_access_token = params[:asana_access_token]
+        token = params[:asana_access_token]
         task_url = params[:task_url]
         template_name = params[:template_name]
         comment = params[:comment]
-        is_scheduled_release = params[:is_scheduled_release] || true
+        is_scheduled_release = params[:is_scheduled_release] || false
         github_handle = params[:github_handle]
 
         automation_subtask_id = AsanaGetReleaseAutomationSubtaskIdAction.run(task_url: task_url, asana_access_token: token)
@@ -31,7 +33,7 @@ def self.run(params)
         end
 
         begin
-          asana_client.tasks.add_followers_for_task(task_gid: task_id, followers: [assignee_id])
+          asana_client.tasks.add_followers_for_task(task_gid: automation_subtask_id, followers: [assignee_id])
         rescue StandardError => e
           UI.user_error!("Failed to add a collaborator to the release task: #{e}")
         end
diff --git a/spec/asana_log_message_spec.rb b/spec/asana_log_message_spec.rb
new file mode 100644
index 0000000..f88a6e8
--- /dev/null
+++ b/spec/asana_log_message_spec.rb
@@ -0,0 +1,71 @@
+describe Fastlane::Actions::AsanaLogMessageAction do
+  describe "#run" do
+    let(:task_url) { "https://example.com" }
+    let(:task_id) { "1" }
+    let(:automation_subtask_id) { "2" }
+    let(:assignee_id) { "11" }
+    let(:comment) { "comment" }
+    let(:github_handle) { "user" }
+
+    before do
+      @asana_client_tasks = double
+      asana_client = double("Asana::Client")
+      allow(Asana::Client).to receive(:new).and_return(asana_client)
+      allow(asana_client).to receive(:tasks).and_return(@asana_client_tasks)
+
+      allow(Fastlane::Actions::AsanaGetReleaseAutomationSubtaskIdAction).to receive(:run).and_return(automation_subtask_id)
+      allow(Fastlane::Actions::AsanaExtractTaskIdAction).to receive(:run).and_return(task_id)
+      allow(Fastlane::Actions::AsanaExtractTaskAssigneeAction).to receive(:run).and_return(assignee_id)
+      allow(Fastlane::Actions::AsanaGetUserIdForGithubHandleAction).to receive(:run).and_return(assignee_id)
+      allow(@asana_client_tasks).to receive(:add_followers_for_task)
+      allow(Fastlane::Actions::AsanaAddCommentAction).to receive(:run)
+    end
+
+    it "does extract assignee id from release task when is scheduled release" do
+      expect(Fastlane::Actions::AsanaExtractTaskIdAction).to receive(:run).with(task_url: task_url)
+      expect(Fastlane::Actions::AsanaExtractTaskAssigneeAction).to receive(:run).with(
+        task_id: task_id,
+        asana_access_token: anything
+      )
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: true)
+    end
+
+    it "does takes assignee id from github handle when is manual release" do
+      expect(Fastlane::Actions::AsanaGetUserIdForGithubHandleAction).to receive(:run).with(
+        github_handle: github_handle,
+        asana_access_token: anything
+      )
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
+    end
+
+    it "adds a assignee as a follower to the automation task" do
+      expect(@asana_client_tasks).to receive(:add_followers_for_task).with(task_gid: automation_subtask_id, followers: [assignee_id])
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
+    end
+
+    it "raises an error if adding a collaborator fails" do
+      allow(Fastlane::UI).to receive(:user_error!)
+      allow(@asana_client_tasks).to receive(:add_followers_for_task).and_raise(StandardError, 'some error')
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
+      expect(Fastlane::UI).to have_received(:user_error!).with("Failed to add a collaborator to the release task: some error")
+    end
+
+    it "adds a comment to the automation subtask" do
+      expect(Fastlane::Actions::AsanaAddCommentAction).to receive(:run).with(
+        task_id: automation_subtask_id,
+        comment: comment,
+        template_name: nil,
+        asana_access_token: anything
+      )
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
+    end
+  end
+
+  def test_action(task_url:, github_handle: nil, comment: nil, template_name: nil, is_scheduled_release: false)
+    Fastlane::Actions::AsanaLogMessageAction.run(task_url: task_url,
+                                                 comment: comment,
+                                                 template_name: template_name,
+                                                 is_scheduled_release: is_scheduled_release,
+                                                 github_handle: github_handle)
+  end
+end

From e28812f9c94a187d6c18ae7fba94b508c3d0a75d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Thu, 5 Sep 2024 22:53:16 +0200
Subject: [PATCH 03/10] Handle missing github handle

---
 .../actions/asana_get_user_id_for_github_handle_action.rb   | 2 +-
 .../actions/asana_log_message_action.rb                     | 4 ++++
 spec/asana_get_user_id_for_github_handle_spec.rb            | 6 +++---
 spec/asana_log_message_spec.rb                              | 5 +++++
 4 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_get_user_id_for_github_handle_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_get_user_id_for_github_handle_action.rb
index 4660e2a..6be093e 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_get_user_id_for_github_handle_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_get_user_id_for_github_handle_action.rb
@@ -15,7 +15,7 @@ def self.run(params)
         asana_user_id = user_mapping[github_handle]
 
         if asana_user_id.nil? || asana_user_id.to_s.empty?
-          UI.warning("Asana User ID not found for GitHub handle: #{github_handle}")
+          UI.message("Asana User ID not found for GitHub handle: #{github_handle}")
         else
           Helper::GitHubActionsHelper.set_output("asana_user_id", asana_user_id)
           asana_user_id
diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
index 06ccd5f..e66316e 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -25,6 +25,10 @@ def self.run(params)
           task_id = AsanaExtractTaskIdAction.run(task_url: task_url)
           assignee_id = AsanaExtractTaskAssigneeAction.run(task_id: task_id, asana_access_token: token)
         else
+          if github_handle.to_s.empty?
+            UI.user_error!("Github handle cannot be empty for manual release")
+            return
+          end
           assignee_id = AsanaGetUserIdForGithubHandleAction.run(github_handle: github_handle, asana_access_token: token)
         end
 
diff --git a/spec/asana_get_user_id_for_github_handle_spec.rb b/spec/asana_get_user_id_for_github_handle_spec.rb
index 7cba8a5..53a6c22 100644
--- a/spec/asana_get_user_id_for_github_handle_spec.rb
+++ b/spec/asana_get_user_id_for_github_handle_spec.rb
@@ -21,17 +21,17 @@
     end
 
     it "shows warning when handle does not exist" do
-      expect(Fastlane::UI).to receive(:warning).with("Asana User ID not found for GitHub handle: chicken")
+      expect(Fastlane::UI).to receive(:message).with("Asana User ID not found for GitHub handle: chicken")
       test_action("chicken")
     end
 
     it "shows warning when handle is nil" do
-      expect(Fastlane::UI).to receive(:warning).with("Asana User ID not found for GitHub handle: pigeon")
+      expect(Fastlane::UI).to receive(:message).with("Asana User ID not found for GitHub handle: pigeon")
       test_action("pigeon")
     end
 
     it "shows warning when handle is empty" do
-      expect(Fastlane::UI).to receive(:warning).with("Asana User ID not found for GitHub handle: hawk")
+      expect(Fastlane::UI).to receive(:message).with("Asana User ID not found for GitHub handle: hawk")
       test_action("hawk")
     end
   end
diff --git a/spec/asana_log_message_spec.rb b/spec/asana_log_message_spec.rb
index f88a6e8..f792662 100644
--- a/spec/asana_log_message_spec.rb
+++ b/spec/asana_log_message_spec.rb
@@ -38,6 +38,11 @@
       test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
     end
 
+    it "raises an error when github handle is empty and is manual release" do
+      expect(Fastlane::UI).to receive(:user_error!).with("Github handle cannot be empty for manual release")
+      test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: "")
+    end
+
     it "adds a assignee as a follower to the automation task" do
       expect(@asana_client_tasks).to receive(:add_followers_for_task).with(task_gid: automation_subtask_id, followers: [assignee_id])
       test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)

From 5820c366fc69d719bd57190d93c3d1a82110f063 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Thu, 5 Sep 2024 23:00:12 +0200
Subject: [PATCH 04/10] Fix typo

---
 .../ddg_apple_automation/actions/asana_log_message_action.rb    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
index e66316e..83d8fed 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -33,7 +33,7 @@ def self.run(params)
         end
 
         asana_client = Asana::Client.new do |c|
-          c.authentication(:access_token, asana_access_token)
+          c.authentication(:access_token, token)
         end
 
         begin

From 5942f555169d4f87ef1c87880899da6a208b36ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Thu, 5 Sep 2024 23:26:19 +0200
Subject: [PATCH 05/10] Fix tests

---
 spec/asana_add_comment_spec.rb | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/spec/asana_add_comment_spec.rb b/spec/asana_add_comment_spec.rb
index ad73522..f5fc15c 100644
--- a/spec/asana_add_comment_spec.rb
+++ b/spec/asana_add_comment_spec.rb
@@ -7,19 +7,21 @@
       asana_client = double("Asana::Client")
       allow(Asana::Client).to receive(:new).and_return(asana_client)
       allow(asana_client).to receive(:stories).and_return(@asana_client_stories)
+
+      ENV["WORKFLOW_URL"] = "http://www.example.com"
     end
 
     it "does not call task id extraction if task id provided" do
       allow(Fastlane::Actions::AsanaExtractTaskIdAction).to receive(:run)
       allow(@asana_client_stories).to receive(:create_story_for_task).and_return(double)
-      test_action(task_id: "123", comment: "comment", workflow_url: "http://www.example.com")
+      test_action(task_id: "123", comment: "comment")
       expect(Fastlane::Actions::AsanaExtractTaskIdAction).not_to have_received(:run)
     end
 
     it "extracts task id if task id not provided" do
       allow(@asana_client_stories).to receive(:create_story_for_task).and_return(double)
       allow(Fastlane::Actions::AsanaExtractTaskIdAction).to receive(:run)
-      test_action(task_url: "https://app.asana.com/0/753241/9999", comment: "comment", workflow_url: "http://www.example.com")
+      test_action(task_url: "https://app.asana.com/0/753241/9999", comment: "comment")
       expect(Fastlane::Actions::AsanaExtractTaskIdAction).to have_received(:run).with(
         task_url: "https://app.asana.com/0/753241/9999"
       )
@@ -46,6 +48,7 @@
 
     it "shows error if provided template does not exist" do
       allow(File).to receive(:read).and_raise(Errno::ENOENT)
+      allow(Fastlane::Helper::DdgAppleAutomationHelper).to receive(:path_for_asset_file).and_return("non-existing.html")
       expect(Fastlane::UI).to receive(:user_error!).with("Error: The file 'non-existing.html' does not exist.")
       expect(@asana_client_stories).not_to receive(:create_story_for_task)
       test_action(task_id: "123", template_name: "non-existing")
@@ -81,7 +84,11 @@
 
     it "correctly builds text payload" do
       allow(@asana_client_stories).to receive(:create_story_for_task)
-      test_action(task_id: "123", comment: "This is a test comment.", workflow_url: "http://github.com/duckduckgo/iOS/actions/runs/123")
+      ClimateControl.modify(
+        WORKFLOW_URL: "http://github.com/duckduckgo/iOS/actions/runs/123"
+      ) do
+        test_action(task_id: "123", comment: "This is a test comment.")
+      end
       expect(@asana_client_stories).to have_received(:create_story_for_task).with(
         task_gid: "123",
         text: "This is a test comment.\n\nWorkflow URL: http://github.com/duckduckgo/iOS/actions/runs/123"
@@ -91,7 +98,7 @@
     it "fails when client raises error" do
       allow(@asana_client_stories).to receive(:create_story_for_task).and_raise(StandardError, "API error")
       expect(Fastlane::UI).to receive(:user_error!).with("Failed to post comment: API error")
-      test_action(task_id: "123", comment: "comment", workflow_url: "http://www.example.com")
+      test_action(task_id: "123", comment: "comment")
     end
   end
 
@@ -99,7 +106,6 @@ def test_action(task_id: nil, task_url: nil, comment: nil, template_name: nil, w
     Fastlane::Actions::AsanaAddCommentAction.run(task_id: task_id,
                                                  task_url: task_url,
                                                  comment: comment,
-                                                 template_name: template_name,
-                                                 workflow_url: workflow_url)
+                                                 template_name: template_name)
   end
 end

From ed36636523ce0726b1fa541737288f51310071f7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Fri, 6 Sep 2024 10:01:34 +0200
Subject: [PATCH 06/10] Provide default value for WORKFLOW_URL env var

---
 .../actions/asana_add_comment_action.rb                     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
index 411a940..110dde1 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
@@ -14,6 +14,8 @@ def self.run(params)
         template_name = params[:template_name]
         comment = params[:comment]
 
+        workflow_url = ENV.fetch('WORKFLOW_URL', '')
+
         begin
           validate_params(task_id, task_url, comment, template_name)
         rescue ArgumentError => e
@@ -24,7 +26,7 @@ def self.run(params)
         task_id = Fastlane::Actions::AsanaExtractTaskIdAction.run(task_url: task_url) if task_url
 
         if template_name.to_s.empty?
-          text = "#{comment}\n\nWorkflow URL: #{ENV.fetch('WORKFLOW_URL')}"
+          text = "#{comment}\n\nWorkflow URL: #{workflow_url}"
           create_story(asana_access_token, task_id, text: text)
         else
           template_file = Helper::DdgAppleAutomationHelper.path_for_asset_file("asana_add_comment/templates/#{template_name}.html")
@@ -89,7 +91,7 @@ def self.validate_params(task_id, task_url, comment, template_name)
           raise ArgumentError, "Both comment and template_name cannot be empty. At least one must be provided."
         end
 
-        if comment && ENV.fetch('WORKFLOW_URL').to_s.empty?
+        if comment && workflow_url.to_s.empty?
           raise ArgumentError, "If comment is provided, workflow_url cannot be empty"
         end
       end

From 889e719804422d871d5e96f767c7ab38b36906fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Fri, 6 Sep 2024 10:05:16 +0200
Subject: [PATCH 07/10] Fix tests

---
 .../ddg_apple_automation/actions/asana_add_comment_action.rb  | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
index 110dde1..9a5e067 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_add_comment_action.rb
@@ -17,7 +17,7 @@ def self.run(params)
         workflow_url = ENV.fetch('WORKFLOW_URL', '')
 
         begin
-          validate_params(task_id, task_url, comment, template_name)
+          validate_params(task_id, task_url, comment, template_name, workflow_url)
         rescue ArgumentError => e
           UI.user_error!(e.message)
           return
@@ -82,7 +82,7 @@ def self.is_supported?(platform)
         true
       end
 
-      def self.validate_params(task_id, task_url, comment, template_name)
+      def self.validate_params(task_id, task_url, comment, template_name, workflow_url)
         if task_id.to_s.empty? && task_url.to_s.empty?
           raise ArgumentError, "Both task_id and task_url cannot be empty. At least one must be provided."
         end

From bf42f3fe26599abd92dd99ccadd5f539b6523cbc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Fri, 6 Sep 2024 13:21:08 +0200
Subject: [PATCH 08/10] PR fixes

---
 .../actions/asana_log_message_action.rb                    | 7 ++++---
 spec/asana_log_message_spec.rb                             | 6 +++---
 2 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
index 83d8fed..9a12a92 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/actions/asana_log_message_action.rb
@@ -16,7 +16,7 @@ def self.run(params)
         task_url = params[:task_url]
         template_name = params[:template_name]
         comment = params[:comment]
-        is_scheduled_release = params[:is_scheduled_release] || false
+        is_scheduled_release = params[:is_scheduled_release]
         github_handle = params[:github_handle]
 
         automation_subtask_id = AsanaGetReleaseAutomationSubtaskIdAction.run(task_url: task_url, asana_access_token: token)
@@ -39,7 +39,7 @@ def self.run(params)
         begin
           asana_client.tasks.add_followers_for_task(task_gid: automation_subtask_id, followers: [assignee_id])
         rescue StandardError => e
-          UI.user_error!("Failed to add a collaborator to the release task: #{e}")
+          UI.user_error!("Failed to add user #{assignee_id} as collaborator on task #{automation_subtask_id}: #{e}")
         end
 
         AsanaAddCommentAction.run(task_id: automation_subtask_id, comment: comment, template_name: template_name, asana_access_token: token)
@@ -84,7 +84,8 @@ def self.available_options
           FastlaneCore::ConfigItem.new(key: :is_scheduled_release,
                                        description: "Indicates whether the release was scheduled or started manually",
                                        optional: true,
-                                       type: Boolean)
+                                       type: Boolean,
+                                       default_value: false)
         ]
       end
 
diff --git a/spec/asana_log_message_spec.rb b/spec/asana_log_message_spec.rb
index f792662..43433e8 100644
--- a/spec/asana_log_message_spec.rb
+++ b/spec/asana_log_message_spec.rb
@@ -21,7 +21,7 @@
       allow(Fastlane::Actions::AsanaAddCommentAction).to receive(:run)
     end
 
-    it "does extract assignee id from release task when is scheduled release" do
+    it "extracts assignee id from release task when is scheduled release" do
       expect(Fastlane::Actions::AsanaExtractTaskIdAction).to receive(:run).with(task_url: task_url)
       expect(Fastlane::Actions::AsanaExtractTaskAssigneeAction).to receive(:run).with(
         task_id: task_id,
@@ -30,7 +30,7 @@
       test_action(task_url: task_url, comment: comment, is_scheduled_release: true)
     end
 
-    it "does takes assignee id from github handle when is manual release" do
+    it "takes assignee id from github handle when is manual release" do
       expect(Fastlane::Actions::AsanaGetUserIdForGithubHandleAction).to receive(:run).with(
         github_handle: github_handle,
         asana_access_token: anything
@@ -43,7 +43,7 @@
       test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: "")
     end
 
-    it "adds a assignee as a follower to the automation task" do
+    it "adds an assignee as follower to the automation task" do
       expect(@asana_client_tasks).to receive(:add_followers_for_task).with(task_gid: automation_subtask_id, followers: [assignee_id])
       test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
     end

From 7cfaca62d2e0a2e9b882e3da586251d200cf9256 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Fri, 6 Sep 2024 13:39:11 +0200
Subject: [PATCH 09/10] Fix test

---
 spec/asana_log_message_spec.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/spec/asana_log_message_spec.rb b/spec/asana_log_message_spec.rb
index 43433e8..c17a900 100644
--- a/spec/asana_log_message_spec.rb
+++ b/spec/asana_log_message_spec.rb
@@ -52,7 +52,7 @@
       allow(Fastlane::UI).to receive(:user_error!)
       allow(@asana_client_tasks).to receive(:add_followers_for_task).and_raise(StandardError, 'some error')
       test_action(task_url: task_url, comment: comment, is_scheduled_release: false, github_handle: github_handle)
-      expect(Fastlane::UI).to have_received(:user_error!).with("Failed to add a collaborator to the release task: some error")
+      expect(Fastlane::UI).to have_received(:user_error!).with("Failed to add user 11 as collaborator on task 2: some error")
     end
 
     it "adds a comment to the automation subtask" do

From 26a7cf6b75fd2db59fa62259683707b3bfcdcdae Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jacek=20=C5=81yp?= <jlyp@duckduckgo.com>
Date: Fri, 6 Sep 2024 14:04:34 +0200
Subject: [PATCH 10/10] Bump version

---
 lib/fastlane/plugin/ddg_apple_automation/version.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/fastlane/plugin/ddg_apple_automation/version.rb b/lib/fastlane/plugin/ddg_apple_automation/version.rb
index 42b314c..2acab82 100644
--- a/lib/fastlane/plugin/ddg_apple_automation/version.rb
+++ b/lib/fastlane/plugin/ddg_apple_automation/version.rb
@@ -1,5 +1,5 @@
 module Fastlane
   module DdgAppleAutomation
-    VERSION = "0.7.0"
+    VERSION = "0.8.0"
   end
 end