From 042648ba20c3ec9b5dc34de879f578ab5df3f7f4 Mon Sep 17 00:00:00 2001
From: Lorenzo Mattei <lmattei@duckduckgo.com>
Date: Thu, 12 Oct 2023 23:00:55 +0200
Subject: [PATCH] Add note about Danger matching rules

---
 Core/AppURLs.swift         | 3 +++
 scripts/update_embedded.sh | 1 +
 2 files changed, 4 insertions(+)

diff --git a/Core/AppURLs.swift b/Core/AppURLs.swift
index 6feb8e7407..e7ebfa07f1 100644
--- a/Core/AppURLs.swift
+++ b/Core/AppURLs.swift
@@ -33,6 +33,9 @@ public extension URL {
     static let aboutLink = URL(string: AppDeepLinkSchemes.quickLink.appending("\(ddg.host!)/about"))!
 
     static let surrogates = URL(string: "\(staticBase)/surrogates.txt")!
+
+    // The following URLs shall match the ones in update_embedded.sh. 
+    // Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update.
     static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v3/ios-config.json")!
     static let trackerDataSet = URL(string: "\(staticBase)/trackerblocking/v5/current/ios-tds.json")!
     static let bloomFilter = URL(string: "\(staticBase)/https/https-mobile-v2-bloom.bin")!
diff --git a/scripts/update_embedded.sh b/scripts/update_embedded.sh
index 892183b2c3..4b60f18eba 100755
--- a/scripts/update_embedded.sh
+++ b/scripts/update_embedded.sh
@@ -60,5 +60,6 @@ performUpdate() {
 	rm -f "$TEMP_ETAG_FILENAME"
 }
 
+# The following URLs shall match the ones in AppURLs.swift. Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update.
 performUpdate 'https://staticcdn.duckduckgo.com/trackerblocking/v5/current/ios-tds.json' "${base_dir}/Core/AppTrackerDataSetProvider.swift" "${base_dir}/Core/trackerData.json"
 performUpdate 'https://staticcdn.duckduckgo.com/trackerblocking/config/v2/ios-config.json' "${base_dir}/Core/AppPrivacyConfigurationDataProvider.swift" "${base_dir}/Core/ios-config.json"