Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 2444c27

Browse files
authored
Remote feature flag for New Tab Page Improvements (#3294)
Task/Issue URL: https://app.asana.com/0/72649045549333/1207539163549338/f Tech Design URL: CC: **Description**: Adds a flag allowing to remotely enable/disable New Tab Page Improvements (sections) feature. Currently used as `.remoteDevelopment`, will be updated to `.remoteReleasable` once the feature is complete. **Steps to test this PR**: 1. Set Internal user flag 2. In Debug menu override Privacy Configuration json to `http://www.jsonblob.com/api/1279014885881929728` 3. Reopen New Tab Page - feature should be visible now **Definition of Done (Internal Only)**: * [ ] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)? --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
1 parent d0ed37f commit 2444c27

File tree

7 files changed

+161
-156
lines changed

7 files changed

+161
-156
lines changed

Configuration/Version.xcconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
MARKETING_VERSION = 7.135.0
1+
MARKETING_VERSION = 7.136.0

Core/AppPrivacyConfigurationDataProvider.swift

+2-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ import BrowserServicesKit
2323
final public class AppPrivacyConfigurationDataProvider: EmbeddedDataProvider {
2424

2525
public struct Constants {
26-
public static let embeddedDataETag = "\"3310d00f227a02b53a16ed4af90afee5\""
27-
public static let embeddedDataSHA = "7371e7fd3293e42638aa3bd3905a205e70827b2fd980848af108c82cedabf8be"
26+
public static let embeddedDataETag = "\"38047fbabac1af7f77112ee692d5d481\""
27+
public static let embeddedDataSHA = "ee998861bbed8b784a7f19caafd76a8f6eb9a82160b0b6ddb21d97e67332b38f"
2828
}
2929

3030
public var embeddedDataEtag: String {

Core/FeatureFlag.swift

+1-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ extension FeatureFlag: FeatureFlagSourceProviding {
7474
case .history:
7575
return .remoteReleasable(.feature(.history))
7676
case .newTabPageSections:
77-
return .internalOnly
77+
return .remoteDevelopment(.feature(.newTabPageImprovements))
7878
case .duckPlayer:
7979
return .remoteReleasable(.feature(.duckPlayer))
8080
case .sslCertificatesBypass:

0 commit comments

Comments
 (0)