Skip to content
This repository was archived by the owner on Feb 24, 2025. It is now read-only.

Commit 63a18b7

Browse files
authored
add assertions for tabs in suggestions (#3394)
Task/Issue URL: https://app.asana.com/0/392891325557410/1208350972189287/f Tech Design URL: CC: @ayoy **Description**: Adds assertions that validate tabs in suggestions and switching tabs Fixes failure check for sending notification in the workflow **Steps to test this PR**: 1. Check this test run passes: https://github.com/duckduckgo/iOS/actions/runs/11037282165 (However End to End tests have not passed for some time so as long as tabs.yaml passes that is the main thing) 3. Run the release/tabs.yaml test locally
1 parent 5424cb1 commit 63a18b7

File tree

2 files changed

+44
-1
lines changed

2 files changed

+44
-1
lines changed

.github/workflows/end-to-end.yml

-1
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ jobs:
103103

104104
steps:
105105
- name: Create Asana task when workflow failed
106-
if: ${{ failure() }}
107106
run: |
108107
curl -s "https://app.asana.com/api/1.0/tasks" \
109108
--header "Accept: application/json" \

.maestro/release_tests/tabs.yaml

+44
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,27 @@ tags:
4646
- assertVisible: ".*Privacy Test Pages.*"
4747
- tapOn: "Refresh Page"
4848

49+
# Suggestions
50+
- assertVisible:
51+
id: "searchEntry"
52+
53+
- tapOn:
54+
id: "searchEntry"
55+
- inputText: "ad click"
56+
- assertVisible: "Switch to Tab.*search-company.site"
57+
- tapOn: "Switch to Tab.*search-company.site"
58+
- assertVisible: ".*Ad Click Flow.*"
59+
60+
- tapOn:
61+
id: "searchEntry"
62+
- inputText: "privacy"
63+
- assertVisible: "Switch to Tab.*privacy-test-pages.site"
64+
- tapOn: "Switch to Tab.*privacy-test-pages.site"
65+
- assertVisible: ".*Privacy Test Pages.*"
66+
67+
# Needed or else test can't see the Tab Switcher button for some reason
68+
- tapOn: "Refresh Page"
69+
4970
# Close Tab
5071
- assertVisible: Tab Switcher
5172
- tapOn: Tab Switcher
@@ -57,3 +78,26 @@ tags:
5778
- assertNotVisible: ".*Ad Click Flow.*"
5879
- assertVisible: "1 Private Tab"
5980
- tapOn: "Done"
81+
82+
# Switch tabs from new tab
83+
- tapOn: "Refresh Page"
84+
- assertVisible: Tab Switcher
85+
- tapOn: Tab Switcher
86+
- assertVisible: ".*Privacy Test Pages.*"
87+
- assertVisible:
88+
id: "Add"
89+
- tapOn:
90+
id: "Add"
91+
- assertVisible:
92+
id: "searchEntry"
93+
- tapOn:
94+
id: "searchEntry"
95+
- inputText: "privacy"
96+
- assertVisible: "Switch to Tab.*privacy-test-pages.site"
97+
- tapOn: "Switch to Tab.*privacy-test-pages.site"
98+
- assertVisible: ".*Privacy Test Pages.*"
99+
- tapOn: "Refresh Page"
100+
- assertVisible: Tab Switcher
101+
- tapOn: Tab Switcher
102+
- assertVisible: "1 Private Tab"
103+

0 commit comments

Comments
 (0)