From 76db01b3838b7a5dd6e4c7dd8b138753f6ec6826 Mon Sep 17 00:00:00 2001 From: Sam Symons Date: Thu, 28 Sep 2023 15:12:18 -0700 Subject: [PATCH] Update CrashCollection to return the crash metric app version (#2046) Task/Issue URL: https://app.asana.com/0/0/1205599209825567/f Tech Design URL: CC: Description: This PR updates the app to use the correct crash app version. See BSK PR here: duckduckgo/BrowserServicesKit#515 --- DuckDuckGo.xcodeproj/project.pbxproj | 2 +- .../project.xcworkspace/xcshareddata/swiftpm/Package.resolved | 4 ++-- DuckDuckGo/AppDelegate.swift | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj index 9c1b12cc09..05ce74308f 100644 --- a/DuckDuckGo.xcodeproj/project.pbxproj +++ b/DuckDuckGo.xcodeproj/project.pbxproj @@ -8944,7 +8944,7 @@ repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit"; requirement = { kind = exactVersion; - version = 80.3.0; + version = 80.4.0; }; }; C14882EB27F211A000D59F0C /* XCRemoteSwiftPackageReference "SwiftSoup" */ = { diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved index fc188f4924..7c8a292a91 100644 --- a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved +++ b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved @@ -15,8 +15,8 @@ "repositoryURL": "https://github.com/DuckDuckGo/BrowserServicesKit", "state": { "branch": null, - "revision": "2bed3ed259ca7bde33f3d41424345acfeff8031d", - "version": "80.3.0" + "revision": "8192bc4708c36fda09667f1e84c2e29d3a725c0c", + "version": "80.4.0" } }, { diff --git a/DuckDuckGo/AppDelegate.swift b/DuckDuckGo/AppDelegate.swift index 9f347056c7..2e804c17ca 100644 --- a/DuckDuckGo/AppDelegate.swift +++ b/DuckDuckGo/AppDelegate.swift @@ -87,7 +87,7 @@ class AppDelegate: UIResponder, UIApplicationDelegate { Configuration.setURLProvider(AppConfigurationURLProvider()) CrashCollection.start { - Pixel.fire(pixel: .dbCrashDetected, withAdditionalParameters: $0, includedParameters: [.appVersion]) + Pixel.fire(pixel: .dbCrashDetected, withAdditionalParameters: $0, includedParameters: []) } clearTmp()