diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift index fe7fbcd154..afb8686677 100644 --- a/Core/PixelEvent.swift +++ b/Core/PixelEvent.swift @@ -216,9 +216,6 @@ extension Pixel { case bookmarkAddFavoriteBySwipe case bookmarkDeletedFromBookmark - case bookmarksUIFavoritesAction - case bookmarksUIFavoritesManage - case bookmarkImportSuccess case bookmarkImportFailure case bookmarkImportFailureParsingDL @@ -1111,9 +1108,6 @@ extension Pixel.Event { case .bookmarkAddFavoriteBySwipe: return "m_add_favorite_by_swipe" case .bookmarkDeletedFromBookmark: return "m_bookmark_deleted_from_bookmark" - case .bookmarksUIFavoritesAction: return "m_bookmarks_ui_favorites_action_daily" - case .bookmarksUIFavoritesManage: return "m_bookmarks_ui_favorites_manage_daily" - case .homeScreenShown: return "mh" case .homeScreenEditFavorite: return "mh_ef" case .homeScreenDeleteFavorite: return "mh_df" diff --git a/DuckDuckGo/BookmarksViewController.swift b/DuckDuckGo/BookmarksViewController.swift index 235afcd895..8d5f56f5ea 100644 --- a/DuckDuckGo/BookmarksViewController.swift +++ b/DuckDuckGo/BookmarksViewController.swift @@ -787,10 +787,6 @@ class BookmarksViewController: UIViewController, UITableViewDelegate { changeEditButtonToDone() configureToolbarMoreItem() refreshFooterView() - - if !favoritesContainer.isHidden { - DailyPixel.fireDaily(.bookmarksUIFavoritesManage) - } } private func finishEditing() { diff --git a/DuckDuckGo/FavoritesHomeViewSectionRenderer.swift b/DuckDuckGo/FavoritesHomeViewSectionRenderer.swift index 0d1646f259..0d295ed592 100644 --- a/DuckDuckGo/FavoritesHomeViewSectionRenderer.swift +++ b/DuckDuckGo/FavoritesHomeViewSectionRenderer.swift @@ -156,7 +156,6 @@ class FavoritesHomeViewSectionRenderer { guard let indexPath = collectionView.indexPath(for: cell), let favorite = viewModel.favorite(at: indexPath.row) else { return } Pixel.fire(pixel: .homeScreenDeleteFavorite) - fireActionPixel() viewModel.removeFavorite(favorite) WidgetCenter.shared.reloadAllTimelines() collectionView.performBatchUpdates { @@ -169,7 +168,6 @@ class FavoritesHomeViewSectionRenderer { guard let indexPath = collectionView.indexPath(for: cell), let favorite = viewModel.favorite(at: indexPath.row) else { return } Pixel.fire(pixel: .homeScreenEditFavorite) - fireActionPixel() controller?.favoritesRenderer(self, didRequestEdit: favorite) } @@ -274,7 +272,7 @@ class FavoritesHomeViewSectionRenderer { let dragItem = coordinator.items.first?.dragItem, let sourcePath = coordinator.items.first?.sourceIndexPath, let destinationPath = coordinator.destinationIndexPath, - let cell = collectionView.cellForItem(at: sourcePath) as? FavoriteHomeCell, + let cell = self.collectionView(collectionView, cellForItemAt: sourcePath) as? FavoriteHomeCell, let favorite = cell.favorite else { return } @@ -287,7 +285,6 @@ class FavoritesHomeViewSectionRenderer { coordinator.drop(dragItem, toItemAt: destinationPath) - fireActionPixel() } func collectionView(_ collectionView: UICollectionView, itemsForBeginning session: UIDragSession, at indexPath: IndexPath) -> [UIDragItem] { @@ -317,9 +314,4 @@ class FavoritesHomeViewSectionRenderer { return UICollectionViewDropProposal(operation: .move, intent: .insertAtDestinationIndexPath) } - /// Actions are only available from the bookmarks UI, so this is safe to send from here. - func fireActionPixel() { - DailyPixel.fire(pixel: .bookmarksUIFavoritesAction) - } - }