From c23d40399856414a4b9807adc80a9a4a0c8a930b Mon Sep 17 00:00:00 2001 From: Daniel Bernal Date: Tue, 9 Jan 2024 15:01:25 +0100 Subject: [PATCH] Removes Home-button temporary pixels (#2027) Task/Issue URL: https://app.asana.com/0/1204099484721401/1205814772815391/f Remove Pixels - "m_mac_home_button_hidden" - "m_mac_home_button_left" - "m_mac_home_button_right" --- .../Preferences/Model/AppearancePreferences.swift | 8 -------- DuckDuckGo/Statistics/PixelEvent.swift | 13 ------------- DuckDuckGo/Statistics/PixelParameters.swift | 5 +---- 3 files changed, 1 insertion(+), 25 deletions(-) diff --git a/DuckDuckGo/Preferences/Model/AppearancePreferences.swift b/DuckDuckGo/Preferences/Model/AppearancePreferences.swift index c7637ba582..ced7a60730 100644 --- a/DuckDuckGo/Preferences/Model/AppearancePreferences.swift +++ b/DuckDuckGo/Preferences/Model/AppearancePreferences.swift @@ -244,14 +244,6 @@ final class AppearancePreferences: ObservableObject { @Published var homeButtonPosition: HomeButtonPosition { didSet { persistor.homeButtonPosition = homeButtonPosition - switch homeButtonPosition { - case .hidden: - Pixel.fire(.homeButtonHidden) - case .left: - Pixel.fire(.homeButtonLeft) - case .right: - Pixel.fire(.homeButtonRight) - } } } diff --git a/DuckDuckGo/Statistics/PixelEvent.swift b/DuckDuckGo/Statistics/PixelEvent.swift index 56e18ad590..8ab6f1ef2d 100644 --- a/DuckDuckGo/Statistics/PixelEvent.swift +++ b/DuckDuckGo/Statistics/PixelEvent.swift @@ -205,11 +205,6 @@ extension Pixel { // DataBrokerProtection Other case dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn - // 28-day Home Button - case homeButtonHidden - case homeButtonLeft - case homeButtonRight - case dailyPixel(Event, isFirst: Bool) enum Debug { @@ -558,14 +553,6 @@ extension Pixel.Event { case .dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn: return "m_mac_dbp_error_when_fetching_subscription_auth_token_after_sign_in" - // 28-day Home Button - case .homeButtonHidden: - return "m_mac_home_button_hidden" - case .homeButtonLeft: - return "m_mac_home_button_left" - case .homeButtonRight: - return "m_mac_home_button_right" - case .dailyPixel(let pixel, isFirst: let isFirst): return pixel.name + (isFirst ? "_d" : "_c") } diff --git a/DuckDuckGo/Statistics/PixelParameters.swift b/DuckDuckGo/Statistics/PixelParameters.swift index 477ee48794..fa511a8030 100644 --- a/DuckDuckGo/Statistics/PixelParameters.swift +++ b/DuckDuckGo/Statistics/PixelParameters.swift @@ -162,10 +162,7 @@ extension Pixel.Event { .dataBrokerProtectionWaitlistCardUITapped, .dataBrokerProtectionWaitlistTermsAndConditionsDisplayed, .dataBrokerProtectionWaitlistTermsAndConditionsAccepted, - .dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn, - .homeButtonLeft, - .homeButtonRight, - .homeButtonHidden: + .dataBrokerProtectionErrorWhenFetchingSubscriptionAuthTokenAfterSignIn: return nil } }