From 658d23cf8ed22173e0bee086c3f66b284f92e4f2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Wed, 16 Aug 2023 10:47:00 +0200 Subject: [PATCH 1/2] ci: set GODEBUG=cgocheck=2 --- .github/workflows/docker.yml | 2 +- .github/workflows/tests.yml | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index b20fe4f41..463b3ff3a 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -136,7 +136,7 @@ jobs: if: '!matrix.qemu' continue-on-error: ${{fromJson(needs.prepare.outputs.push)}} run: | - docker run --platform=${{matrix.platform}} --rm \ + docker run --platform=${{matrix.platform}} --env GODEBUG=cgocheck=2 --rm \ $(jq -r '."builder-${{matrix.variant}}"."containerimage.config.digest"' <<< $METADATA) \ "sh -c 'frankenphp version && go test ${{matrix.race}} -v ./... && cd caddy && go test ${{matrix.race}} -v ./...'" env: diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index a753d0323..3f08a7ba2 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -3,6 +3,8 @@ on: [push, pull_request] jobs: tests: runs-on: ubuntu-latest + env: + GODEBUG: cgocheck=2 strategy: matrix: php-versions: ['8.2', '8.3'] From 2432cb066a46fc9527dfadb509686d321888224b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Wed, 16 Aug 2023 11:15:06 +0200 Subject: [PATCH 2/2] feat: disable cgochecks in Docker images --- Dockerfile | 2 ++ alpine.Dockerfile | 2 ++ 2 files changed, 4 insertions(+) diff --git a/Dockerfile b/Dockerfile index 59f7a4cab..d94ba56bf 100644 --- a/Dockerfile +++ b/Dockerfile @@ -50,6 +50,8 @@ ENTRYPOINT ["/bin/bash","-c"] FROM php-base AS runner +ENV GODEBUG=cgocheck=0 + COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin/ WORKDIR /app diff --git a/alpine.Dockerfile b/alpine.Dockerfile index e2017fd92..c78d67ad4 100644 --- a/alpine.Dockerfile +++ b/alpine.Dockerfile @@ -49,6 +49,8 @@ ENTRYPOINT ["/bin/sh","-c"] FROM php-base AS runner +ENV GODEBUG=cgocheck=0 + COPY --from=mlocati/php-extension-installer /usr/bin/install-php-extensions /usr/local/bin/ WORKDIR /app