Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility of implementing this as a facade #5

Open
ryankurte opened this issue Jul 13, 2020 · 5 comments
Open

Possibility of implementing this as a facade #5

ryankurte opened this issue Jul 13, 2020 · 5 comments

Comments

@ryankurte
Copy link

hey, would you be interested in feature-gating this to act as a facade so std would expose the standard library types and not(std) would expose the local crate types? this would make it easier to write libraries that are agnostic over std/no_std, but still work with third party networking components in the std case.

this would be useful prior to rust-lang/rfcs#2832 landing and being implemented, and for types not included in this RFC (SocketAddr etc.)

nominally it would be good to test to ensure each variant provides the same interfaces as part of this (and any variation in interfaces would ideally be resolved, which may be a braking change), but practically introducing the feature-gate without anything else would still help a bunch.

@dunmatt
Copy link
Owner

dunmatt commented Dec 2, 2020

Sorry for the delay on this, somehow the notification email got lost in the churn. I'll give it it the requisite thought tonight and let you know, but from what you've said so far it seems utterly reasonable.

@dunmatt
Copy link
Owner

dunmatt commented Dec 3, 2020

Yeah, I'm on board. Did you want to make the change or shall I?

@ryankurte
Copy link
Author

ryankurte commented Dec 3, 2020

it's not high up on my list at the moment but, would be super handy. happy to review a PR if it's useful for you / you get there before i do!

@chrysn
Copy link

chrysn commented Dec 15, 2022

What is left of this after #13? (It mentioned it was only partial).

Or is this intended to stay open until the whole crate is a facade (after rust-lang/rust#104265, provided RFC2832 passes)?

@dunmatt
Copy link
Owner

dunmatt commented Dec 15, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants