Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not recognize multiple background-images properly #13

Open
dominicbarnes opened this issue Aug 3, 2015 · 5 comments
Open

Does not recognize multiple background-images properly #13

dominicbarnes opened this issue Aug 3, 2015 · 5 comments

Comments

@dominicbarnes
Copy link

When using multiple backgrounds, this module does not parse url() declarations after the first one properly:

a {
  background-image: url('./logo.png'), url('./caret.png');
}

The first one (./logo.png) gets parsed correctly, but the 2nd (./caret.png) is not detected. (and is not rewritten by the consumer)

@matthewmueller
Copy link
Contributor

yikes, maybe we should just move towards using postcss or css-parse :-/

this could probably be fixed up, but I wonder if it's worth it if these issues keep coming up.

@dominicbarnes
Copy link
Author

Yeah, I totally see that being a valuable way to offload this effort. fwiw, I've also considered adopting rework to handle CSS in duo-pack, because generating source-maps and stuff by hand is proving extremely difficult once things start operating recursively. :(

@matthewmueller
Copy link
Contributor

yah i'm +1 to this change. originally it was to speed up the parsing, but i didn't realize the complexity and developer cost plain regexps would bring.

@dominicbarnes
Copy link
Author

Cool, would you mind moving this to the duojs organization?

@matthewmueller
Copy link
Contributor

done, added you on npm as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants