Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CommitteeSize comment #1525

Closed
wants to merge 0 commits into from
Closed

Fix CommitteeSize comment #1525

wants to merge 0 commits into from

Conversation

fed-franz
Copy link
Contributor

No description provided.

@fed-franz fed-franz linked an issue Apr 21, 2023 that may be closed by this pull request
Fix committee size comments #1519
Open
@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023 •
edited
Loading

Codecov Report

Patch coverage: 20.34% and project coverage change: -0.14 ⚠️

Comparison is base (57c6bbd) 40.18% compared to head (b5260a1) 40.04%.

❗ Current head b5260a1 differs from pull request most recent head ce871eb. Consider uploading reports for the commit ce871eb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
- Coverage   40.18%   40.04%   -0.14%     
==========================================
  Files         147      147              
  Lines        9651     9791     +140     
==========================================
+ Hits         3878     3921      +43     
- Misses       5144     5239      +95     
- Partials      629      631       +2
Impacted Files Coverage Δ
pkg/config/genesis/config.go 0.00% <ø> (ø)
pkg/core/consensus/agreement/checkcert.go 6.97% <0.00%> (ø)
...nsensus/blockgenerator/candidate/blockgenerator.go 0.00% <0.00%> (ø)
...core/consensus/blockgenerator/candidate/genesis.go 0.00% <0.00%> (ø)
...kg/core/consensus/blockgenerator/candidate/mock.go 0.00% <0.00%> (ø)
pkg/core/consensus/committee/handler.go 70.21% <ø> (ø)
pkg/core/data/block/block.go 8.97% <0.00%> (-1.48%) ⬇️
pkg/core/data/block/certificate.go 0.00% <ø> (ø)
pkg/core/data/block/header.go 0.00% <0.00%> (ø)
pkg/core/data/ipc/transactions/fixtures.go 13.76% <0.00%> (-0.21%) ⬇️
... and 17 more

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fed-franz fed-franz closed this May 2, 2023
@fed-franz fed-franz force-pushed the 1519-fix-committee-size-comments branch from ce871eb to 2db9a3c Compare May 2, 2023 14:43
@fed-franz fed-franz self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fed-franz fed-franz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix committee size comments
2 participants
@fed-franz @codecov-commenter