Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector created by the legacy and main branches vectors.bin is different #3

Open
JIA-HONG-CHU opened this issue Aug 27, 2024 · 1 comment

Comments

@JIA-HONG-CHU
Copy link

I know that legacy uses openaiclip's github and main branch uses clip_trt's github. I used main branch to make coco's vector.bin and the search perfomance is very bad. I would like to ask where I didn't notice it?

@dusty-nv
Copy link
Owner

dusty-nv commented Sep 2, 2024

Hello!, yes I recall there being some question of projected vs non (this is unrelated to another mm_projector from VLM) and it resulting in embeddings of dimension 1024 vs 768. clip_trt is using HuggingFace for CLIP/SigLIP vs the legacy branch used openai directly, so will have to double-check exactly which weights are being used to restore the performance building new indexes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants