Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep tool maintained and put into practice #2

Open
chrwm opened this issue May 16, 2024 · 4 comments
Open

Keep tool maintained and put into practice #2

chrwm opened this issue May 16, 2024 · 4 comments

Comments

@chrwm
Copy link

chrwm commented May 16, 2024

Hi David, I'd like to keep your great work alive and put the code in practice. I'd also like to add a feature in the future.

To do so, I think as we discussed already in the meeting, when you presented the tool, the best way would be to move it into the OEFamily or RL-institut organisation. Let me know what you think.

@jh-RLI @nesnoj Where would be the better place you think?
In my opinion the OEFamily.

@nesnoj
Copy link
Collaborator

nesnoj commented May 21, 2024

Hey @chrwm, thanks for picking up on this! I'd like to see the tool in action as well and I think the OEFamily is a good place. If you agree, I can create a 1:1 copy..

@jh-RLI
Copy link
Collaborator

jh-RLI commented May 21, 2024

Hey @chrwm I totally agree with you - My short answer to this is: Let's move this to the OEFamily. I already talked to David about this on his last day at RLI and (I think) he agreed.

The long answer:
I think it's fine to use/maintain this as a new, independent module (in its own repo), but in general it would be better to integrate/import this into other tools that already exist in the OEF. Users would then only need to install one package that provides all the functionality for the command line or for custom scripts.

There is the oep-client, which should become THE tool for all users. Since this tool here already uses the oep_client, we would have to redesign the code a bit, I suppose. The benefit would be that we provide a clean interface and bundle the functionality of our multiple tools into one.

Looking at the list of features this tool here offers, some of them would also be useful if made available via the OEP UI, e.g. Users should be able to download a collection of data. The Databus also offers a function to create a collection, which could lead to conflicts in the future. But since we don't have something like this in the OEP, I would still like to have it available.

To summarise, I think this tool is great and we want to have it in the OEF. Nevertheless, we need to consider whether some functions are already fully or at least parts of it available elsewhere and also group functions (e.g. everything related to download/upload).

@dvdstrzl
Copy link
Owner

dvdstrzl commented Jun 5, 2024

Hey @ all,
I'm glad to hear that the tool is useful and is considered to be integrated into the OEF! Feel free to decide how/where it fits best and what could be customized/extended/improved.
If you need support from me in the process, please write me anytime. I will try to respond and help in a timely manner if possible.

@jh-RLI
Copy link
Collaborator

jh-RLI commented Jul 23, 2024

Hey again,

I have invited you to the Open Energy Family org. on GitHub. You should have received an email.
After that I will give you write permissions so you can create a repo in the organisation.

You are free to decide if you want to add this tool to the collection :)
https://docs.github.com/en/repositories/creating-and-managing-repositories/transferring-a-repository#transferring-a-repository-owned-by-your-personal-account

You receive admin rights for this repository so that you continue to have full control.

Later on we can decide where we want to use this tool.
It would be cool to have a documentation page (e.g. mkdocs) and host in on github pages ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants