Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dwmkerr/angular-modal-service
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: dwmkerr/angular-modal-service
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Loading
Showing with 32,925 additions and 688 deletions.
  1. +48 −0 .circleci/config.yml
  2. +3 −0 .codacy.yml
  3. +2 −0 .github/FUNDING.yml
  4. +6 −0 .gitignore
  5. +0 −9 .travis.yml
  6. +65 −1 CHANGELOG.md
  7. +0 −69 Gruntfile.js
  8. +299 −47 README.md
  9. +4 −5 bower.json
  10. +2 −149 dst/angular-modal-service.js
  11. +1 −0 dst/angular-modal-service.js.map
  12. +1 −3 dst/angular-modal-service.min.js
  13. +1 −1 dst/angular-modal-service.min.js.map
  14. +2 −0 index.js
  15. +82 −0 karma.conf.js
  16. +12,181 −0 package-lock.json
  17. +30 −18 package.json
  18. +4 −3 samples/complex/complex.html
  19. +71 −15 samples/complex/complexcontroller.js
  20. +46 −0 samples/custom/custom.css
  21. +8 −30 samples/custom/custom.html
  22. +2 −7 samples/custom/customcontroller.js
  23. +26 −8 samples/index.html
  24. +27 −7 samples/sampleapp.js
  25. +587 −0 samples/vendor/bootstrap/css/bootstrap-theme.css
  26. +1 −0 samples/vendor/bootstrap/css/bootstrap-theme.css.map
  27. +6 −0 samples/vendor/bootstrap/css/bootstrap-theme.min.css
  28. +1 −0 samples/vendor/bootstrap/css/bootstrap-theme.min.css.map
  29. +6,760 −0 samples/vendor/bootstrap/css/bootstrap.css
  30. +1 −0 samples/vendor/bootstrap/css/bootstrap.css.map
  31. +6 −0 samples/vendor/bootstrap/css/bootstrap.min.css
  32. +1 −0 samples/vendor/bootstrap/css/bootstrap.min.css.map
  33. +2,363 −0 samples/vendor/bootstrap/js/bootstrap.js
  34. +7 −0 samples/vendor/bootstrap/js/bootstrap.min.js
  35. +9,210 −0 samples/vendor/jquery/jquery.js
  36. +5 −0 samples/vendor/jquery/jquery.min.js
  37. +1 −0 samples/vendor/jquery/jquery.min.map
  38. +4 −4 samples/yesno/yesnocontroller.js
  39. +0 −7 server.js
  40. +310 −140 src/angular-modal-service.js
  41. +6 −6 test/basics.spec.js
  42. +70 −0 test/bodyClass.spec.js
  43. +63 −0 test/close.spec.js
  44. +52 −0 test/closeModals.spec.js
  45. +48 −0 test/component.spec.js
  46. +47 −0 test/configOptions.spec.js
  47. +182 −19 test/controller.spec.js
  48. +164 −38 test/dom.spec.js
  49. +8 −0 test/index.js
  50. +0 −74 test/karma.config.js
  51. +30 −14 test/parameters.spec.js
  52. +42 −14 test/template.spec.js
  53. +39 −0 webpack.config.js
48 changes: 48 additions & 0 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
version: 2
jobs:
build:
working_directory: ~/project
docker:
- image: circleci/node:8-browsers
environment:
CHROME_BIN: "/usr/bin/google-chrome"
steps:
- checkout
- run:
name: update-npm
command: 'sudo npm install -g npm@latest'
- restore_cache:
key: dependency-cache-{{ checksum "package.json" }}
- run:
name: install-npm
command: npm install
- save_cache:
key: dependency-cache-{{ checksum "package.json" }}
paths:
- ./node_modules
- run:
name: test
command: npm test
- run:
name: upload coverage
command: bash <(curl -s https://codecov.io/bash)
- store_artifacts:
path: dst
destination: dst
- store_artifacts:
path: test-results.xml
destination: tests
- store_artifacts:
path: coverage
destination: coverage
- store_test_results:
path: ./build/test-results.xml
workflows:
version: 2
build:
jobs:
- build:
# All branches, all tags.
filters:
tags:
only: /.*/
3 changes: 3 additions & 0 deletions .codacy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
exclude_paths:
- ./dst/.
- '*.min.js'
2 changes: 2 additions & 0 deletions .github/FUNDING.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Support 'GitHub Sponsors' funding.
github: dwmkerr
6 changes: 6 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
bower_components
node_modules
build
.DS_Store
.idea

artifacts/


9 changes: 0 additions & 9 deletions .travis.yml

This file was deleted.

66 changes: 65 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,67 @@
# Changelog

All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.

### [0.15.6](https://github.com/dwmkerr/angular-modal-service/compare/v0.15.5...v0.15.6) (2020-04-28)

### [0.15.5](https://github.com/dwmkerr/angular-modal-service/compare/v0.15.4...v0.15.5) (2020-04-28)

### [0.15.4](https://github.com/dwmkerr/angular-modal-service/compare/v0.15.3...v0.15.4) (2020-04-28)

## v0.15.0

* Support for a globally configurable close timeout. Thanks [decherneyge](https://github.com/decherneyge).
* Support for selector for `appendElement`. Thanks [decherneyge](https://github.com/decherneyge).
* Tooling version updates.

## v0.7.12

* Support for configuration of the `$locationChangeSuccess` event. Thanks [smalbs](https://github.com/smalbs).

## v0.6.12

* When a model is opened, we blur any active element. Thanks [samx](https://github.com/samwx)!

## v0.6.11

* Robustness for 'locationChangeEvent'.
* Robustness if the body element changs.
* Addded `bower` as a dev dependency. Run `bower install` as an `npm` `postinstall` step, which makes initial setup on a clean machine slightly easier.

## v0.6.10

* Added support for using a custom parent scope for the controller scope, via the `scope` option.
* Fixed a bug with controllerAs vs `controller as`.

## v0.6.6

* Removed calls to $q `catch` and replaced with `then(null, f)` so that the code works in
IE8 (ECMAScript 3).

## v0.6.5

* Reverted changes below as they led to a bug with injected `$element` in modal controller.
Added a test to protect against this case in the future.

## v0.6.4

* Merged `scope` option field. Updated readme.

## v0.6.3

* Fixed memory leak.

## v0.6.2

* Tidied up logic for cleanup.
* Fixed issue with vendor files.

## v0.6.1

* Moved from grunt to gulp.

## v0.6

## v0.5

* Updated the dependencies to use AngularJS 1.3 and upwards.
@@ -8,4 +72,4 @@

* The modal can now be added to any specific element in the DOM. If
unspecified, the modal is added to the `body`, as before.
Thanks [cointilt](https://github.com/cointilt)!
Thanks [cointilt](https://github.com/cointilt)!
69 changes: 0 additions & 69 deletions Gruntfile.js

This file was deleted.

Loading