Internal server error when adding book to database

[ZooeyMiller]

When adding a book to the database I got an internal server error, I'm unsure what caused this, but when I refreshed the book had been properly added.

This warrants further investigation.

[iteles]

I got the same internal server error when I logged in for the first time.
Granted access and got internal server error but when I refreshed, I was logged in.

[finnhodgkin]

The bug was there, I re-deployed through the Heroku dashboard and now it seems to be working again. I didn't even change anything, I was just prepping a debug branch with logs in a bunch of places but thought I'd try a restart first 😢

I hate problems that fix themselves, it's so frustrating!

[finnhodgkin]

I couldn't get the login bug to repeat. I'll try it on another Github account in another browser to double check 👍 Update couldn't get it to repeat with a clean account/no cookies.

Before restarting I checked the logs and the search/add seemed to be breaking on the Google API search, which to be fair on first inspection does have some unreliable code like the following:

...
map
  |> Map.get("items")
  |> Enum.reduce([], fn (%{"volumeInfo" => map}, acc) ->
...

If the map doesn't have items (which it won't if there are any problems with the API call) then Enum.reduce will attempt to run on nil and crash.