Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lotsa Warnings ... ⚠️> Update Phoenix/Elixir Dependencies #85

Open
3 tasks
nelsonic opened this issue Jun 26, 2019 · 2 comments
Open
3 tasks

Lotsa Warnings ... ⚠️> Update Phoenix/Elixir Dependencies #85

nelsonic opened this issue Jun 26, 2019 · 2 comments

Comments

@nelsonic
Copy link
Member

When running (compiling) the project on localhost using Elixir 1.8.1 we see many warnings ...
image

Most (if not all) of these are due to the underlying libraries Phoenix, Ecto, Poison, etc. being out-of-date. So we need to run mix deps.update and fix any broken tests.

Todo

  • Update all Elixir/Phoenix packages to latest versions
  • Fix any broken tests
  • ideally we should have --warnings-as-errors enabled in a project that is kept up-to-date.
    That way anyone working on the project will immediately see when a warning appears.
    It was removed in f38b2c4 to make Travis-CI pass, but I feel it should be re-instated.
@nelsonic nelsonic changed the title Lotsa Warnings ... ⚠️ Lotsa Warnings ... ⚠️> Update Phoenix/Elixir Dependencies Jun 26, 2019
@nelsonic nelsonic mentioned this issue Jun 27, 2019
3 tasks
@nelsonic
Copy link
Member Author

Pre-commit (credo) fails on master:
image

Pre-commit hook is not documented ... 😞 #87

@nelsonic
Copy link
Member Author

@iteles given that this project is not in active use (yet!) I've downgraded the priority of this issue to P2.
(I'm busy trying to find/filter the P1's and see what needs to be done next ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants