From feb65a966619f3463348c4daed60b067478b2887 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 17:38:42 -0800 Subject: [PATCH 01/14] Add swiftlint format --- .github/workflows/SwiftLint.yml | 2 +- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index f1637c99..292ed51c 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -39,5 +39,5 @@ jobs: echo "No Swift files to lint." else echo "Linting changed Swift files..." - swiftlint --config dydx/.swiftlint.yml --fix lint -- $SWIFT_FILES + swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index eb1e1db9..f6f564b4 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From 7cb0646f454207751e13dac5dda9d3babfc614cd Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 17:44:58 -0800 Subject: [PATCH 02/14] Push changes --- .github/workflows/SwiftLint.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 292ed51c..f1ed483a 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -1,6 +1,6 @@ name: SwiftLint on Changed Files -on: [pull_request] +on: push jobs: swiftlint: @@ -41,3 +41,6 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi + git commit -am "SwiftLint" + git push + From a39447c9bb0ddcf470aaff9de158d851f25b08c7 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 17:46:09 -0800 Subject: [PATCH 03/14] Test --- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index f6f564b4..f944e984 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From ce99e14ee7f45ce776c92a1a2e1d6592deee26ab Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 17:54:05 -0800 Subject: [PATCH 04/14] Fix --- .github/workflows/SwiftLint.yml | 6 ++++-- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index f1ed483a..67c1c1c0 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,6 +41,8 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - git commit -am "SwiftLint" - git push + if [ 'git diff --quiet HEAD` -eq 1 ]; then + git commit -am "SwiftLint" + git push + fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index f944e984..053cef32 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From 672b0e8dc85859eb7bcd0a94b104bdf7794d1ae7 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 17:55:34 -0800 Subject: [PATCH 05/14] Fix --- .github/workflows/SwiftLint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 67c1c1c0..18f6f920 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,7 +41,7 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - if [ 'git diff --quiet HEAD` -eq 1 ]; then + if [ `git diff --quiet HEAD` -eq 1 ]; then git commit -am "SwiftLint" git push fi From 1aad8bff3885ae6bd5bfa95c8cb41f90b0af2b83 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:03:47 -0800 Subject: [PATCH 06/14] Fix --- .github/workflows/SwiftLint.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 18f6f920..2a995978 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -17,7 +17,7 @@ jobs: id: changes # Set outputs using the command. run: | - echo "::set-output name=all::$(git diff --name-only --diff-filter=ACMRT ${{ github.event.pull_request.base.sha }} ${{ github.sha }} | xargs)" + echo "::set-output name=all::$(git diff --name-only --diff-filter=AM ${{ github.event.before }} ${{ github.sha }} | xargs)" - name: Install SwiftLint run: brew install swiftlint From 1cd32a7eabd22892dbd6482bbb1ae34fa12d7f07 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:06:53 -0800 Subject: [PATCH 07/14] Test --- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index 053cef32..952f66b1 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From f5508f5b824016e458d76159b9bf8530676a05f2 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:12:49 -0800 Subject: [PATCH 08/14] Fix --- .github/workflows/SwiftLint.yml | 3 ++- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 2a995978..05a8fbea 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,7 +41,8 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - if [ `git diff --quiet HEAD` -eq 1 ]; then + changed=`git diff --quiet HEAD > /dev/null 2>&1` + if [ $changed -ne 0 ]; then git commit -am "SwiftLint" git push fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index 952f66b1..b9716f4e 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From 0515ef5ef92d0409f9572c19470b88f0e6602b0e Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:17:42 -0800 Subject: [PATCH 09/14] Debug --- .github/workflows/SwiftLint.yml | 5 +++-- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 05a8fbea..f3b53b79 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -33,6 +33,7 @@ jobs: # Extract changed files and filter for Swift files FILES="${{ steps.changes.outputs.all }}" SWIFT_FILES=$(echo "$FILES" | grep -E '\.(swift)$' | xargs) + echo $SWIFT_FILES # Run SwiftLint on each changed Swift file # If no Swift files changed, skip the step if [ -z "$SWIFT_FILES" ]; then @@ -41,8 +42,8 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - changed=`git diff --quiet HEAD > /dev/null 2>&1` - if [ $changed -ne 0 ]; then + CHANGED=`git diff --quiet HEAD > /dev/null 2>&1` + if [ $CHANGED -ne 0 ]; then git commit -am "SwiftLint" git push fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index b9716f4e..f944e984 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From 471d4989c43c4480b33b7de22e6fe60ae1f0596d Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:23:44 -0800 Subject: [PATCH 10/14] Fix --- .github/workflows/SwiftLint.yml | 5 +---- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index f3b53b79..53132399 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -33,7 +33,6 @@ jobs: # Extract changed files and filter for Swift files FILES="${{ steps.changes.outputs.all }}" SWIFT_FILES=$(echo "$FILES" | grep -E '\.(swift)$' | xargs) - echo $SWIFT_FILES # Run SwiftLint on each changed Swift file # If no Swift files changed, skip the step if [ -z "$SWIFT_FILES" ]; then @@ -42,9 +41,7 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - CHANGED=`git diff --quiet HEAD > /dev/null 2>&1` - if [ $CHANGED -ne 0 ]; then + if ! git diff --cached --quiet; then git commit -am "SwiftLint" git push fi - diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index f944e984..013e9458 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From 54194c97731f948db93c53a2ec8e946e4c8674dd Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:29:52 -0800 Subject: [PATCH 11/14] Fix --- .github/workflows/SwiftLint.yml | 1 + .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 53132399..fc1e4b1e 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -42,6 +42,7 @@ jobs: swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi if ! git diff --cached --quiet; then + git add . git commit -am "SwiftLint" git push fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index 013e9458..952f66b1 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From e1412ee3632cd8e137db2b6e3799cb27329afcaa Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:38:57 -0800 Subject: [PATCH 12/14] Test --- .github/workflows/SwiftLint.yml | 4 ++-- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index fc1e4b1e..a599cf6b 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,8 +41,8 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - if ! git diff --cached --quiet; then + # if ! git diff --cached --quiet; then git add . git commit -am "SwiftLint" git push - fi + # fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index 952f66b1..f944e984 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From f748523dde6a51309f2d0228e8b785861908dd90 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:40:25 -0800 Subject: [PATCH 13/14] test --- .github/workflows/SwiftLint.yml | 10 +++++----- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index a599cf6b..4257c335 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,8 +41,8 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - # if ! git diff --cached --quiet; then - git add . - git commit -am "SwiftLint" - git push - # fi + # if ! git diff --cached --quiet; then + git add . + git commit -am "SwiftLint" + git push + # fi diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index f944e984..b9716f4e 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav) From e847835193466261c145eacf37987b6d57aba724 Mon Sep 17 00:00:00 2001 From: Rui Date: Mon, 6 Nov 2023 18:44:16 -0800 Subject: [PATCH 14/14] Tesgt --- .github/workflows/SwiftLint.yml | 13 +++++++++---- .../_v4/MarketInfo/dydxMarketInfoViewBuilder.swift | 2 +- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.github/workflows/SwiftLint.yml b/.github/workflows/SwiftLint.yml index 4257c335..db8d43f2 100644 --- a/.github/workflows/SwiftLint.yml +++ b/.github/workflows/SwiftLint.yml @@ -41,8 +41,13 @@ jobs: echo "Linting changed Swift files..." swiftlint --config dydx/.swiftlint.yml --fix --format lint -- $SWIFT_FILES fi - # if ! git diff --cached --quiet; then + + - name: Commit and push if needed + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + git config --global user.name 'github-actions' + git config --global user.email 'github-actions@github.com' git add . - git commit -am "SwiftLint" - git push - # fi + git commit -m "Apply SwiftLint fixes" || true # Commit if there are changes; do nothing if there are none + git push || echo "No changes to push" diff --git a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift index b9716f4e..b92d6ee1 100644 --- a/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift +++ b/dydx/dydxPresenters/dydxPresenters/_v4/MarketInfo/dydxMarketInfoViewBuilder.swift @@ -16,7 +16,7 @@ import dydxStateManager import Abacus public class dydxMarketInfoViewBuilder: NSObject, ObjectBuilderProtocol { - public func build() -> T? { + public func build() -> T? { let presenter = dydxMarketInfoViewPresenter() let view = presenter.viewModel?.createView() ?? PlatformViewModel().createView() let viewController = dydxMarketInfoViewController(presenter: presenter, view: view, configuration: .nav)